Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: src/trusted/debug_stub/target.cc

Issue 10896004: Don't modify memory access right when changing data in debug stub. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/trusted/debug_stub/target.cc
===================================================================
--- src/trusted/debug_stub/target.cc (revision 9612)
+++ src/trusted/debug_stub/target.cc (working copy)
@@ -98,7 +98,7 @@
delete[] data;
return false;
}
- if (IPlatform::SetMemory(address, bp->size_, bp->code_) == false) {
+ if (IPlatform::SetMemory(nap_, address, bp->size_, bp->code_) == false) {
delete[] data;
return false;
}
@@ -127,7 +127,7 @@
breakMap_.erase(cur);
// Copy back the old code, and free the data
- if (!IPlatform::SetMemory(addr, bp_def->size_, data))
+ if (!IPlatform::SetMemory(nap_, addr, bp_def->size_, data))
NaClLog(LOG_ERROR, "Failed to undo breakpoint.\n");
delete[] data;
@@ -490,7 +490,7 @@
nacl::scoped_array<uint8_t> block(new uint8_t[len]);
pktIn->GetBlock(block.get(), len);
- if (!port::IPlatform::SetMemory(sys_addr, len, block.get())) {
+ if (!port::IPlatform::SetMemory(nap_, sys_addr, len, block.get())) {
err = FAILED;
break;
}

Powered by Google App Engine
This is Rietveld 408576698