Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Unified Diff: src/trusted/debug_stub/win/platform_impl.cc

Issue 10896004: Don't modify memory access right when changing data in debug stub. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client/
Patch Set: rebase Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/trusted/debug_stub/target.cc ('k') | tests/gdb/call_from_gdb.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/trusted/debug_stub/win/platform_impl.cc
===================================================================
--- src/trusted/debug_stub/win/platform_impl.cc (revision 9621)
+++ src/trusted/debug_stub/win/platform_impl.cc (working copy)
@@ -11,6 +11,7 @@
#include <exception>
+#include "native_client/src/include/nacl_compiler_annotations.h"
#include "native_client/src/shared/platform/nacl_log.h"
#include "native_client/src/trusted/debug_stub/abi.h"
#include "native_client/src/trusted/debug_stub/platform.h"
@@ -47,7 +48,9 @@
return true;
}
-bool IPlatform::SetMemory(uint64_t virt, uint32_t len, void *src) {
+bool IPlatform::SetMemory(struct NaClApp *nap, uint64_t virt, uint32_t len,
+ void *src) {
+ UNREFERENCED_PARAMETER(nap);
uint32_t oldFlags = Reprotect(reinterpret_cast<void*>(virt),
len, PAGE_EXECUTE_READWRITE);
« no previous file with comments | « src/trusted/debug_stub/target.cc ('k') | tests/gdb/call_from_gdb.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698