Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1089563002: Add johnme@ as an OWNER of content/ Notification code. (Closed)

Created:
5 years, 8 months ago by Peter Beverloo
Modified:
5 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, peter+watch_chromium.org, jam, mlamouri+watch-notifications_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add johnme@ as an OWNER of content/ Notification code. R=mvanouwerkerk@chromium.org BUG= Committed: https://crrev.com/bb4611c679cfec28fe30c99b9629dcec418c4ecd Cr-Commit-Position: refs/heads/master@{#325227}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M content/browser/notifications/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M content/child/notifications/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Peter Beverloo
PTAL John has been a good steward of the code by providing great reviews :-).
5 years, 8 months ago (2015-04-15 11:30:57 UTC) #2
Michael van Ouwerkerk
lgtm
5 years, 8 months ago (2015-04-15 11:33:39 UTC) #3
johnme
thanks, lgtm :)
5 years, 8 months ago (2015-04-15 11:34:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1089563002/1
5 years, 8 months ago (2015-04-15 11:34:43 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-15 12:02:35 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 12:03:28 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bb4611c679cfec28fe30c99b9629dcec418c4ecd
Cr-Commit-Position: refs/heads/master@{#325227}

Powered by Google App Engine
This is Rietveld 408576698