Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1089543005: [Files.app] Added tabindex test for open dialog (Closed)

Created:
5 years, 8 months ago by yoshiki
Modified:
5 years, 8 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Files.app] Added tabindex test for open dialog BUG=469061 TEST=run newly added test Committed: https://crrev.com/afc064b15352fbdfea8e9eb8f9abd3ec03e2eb49 Cr-Commit-Position: refs/heads/master@{#325397}

Patch Set 1 #

Patch Set 2 : fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -3 lines) Patch
M chrome/browser/chromeos/file_manager/file_manager_browsertest.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/main.html View 1 1 chunk +3 lines, -3 lines 0 comments Download
M ui/file_manager/integration_tests/file_manager/tab_index.js View 1 chunk +64 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
yoshiki
@fukino-san, PTAL. Thanks.
5 years, 8 months ago (2015-04-16 02:33:55 UTC) #2
fukino
lgtm. Thanks!
5 years, 8 months ago (2015-04-16 05:03:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1089543005/20001
5 years, 8 months ago (2015-04-16 05:55:24 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-16 06:23:31 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 06:24:25 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/afc064b15352fbdfea8e9eb8f9abd3ec03e2eb49
Cr-Commit-Position: refs/heads/master@{#325397}

Powered by Google App Engine
This is Rietveld 408576698