Issue 1089533002: Abort incremental marking in test-heap/WeakCellsWithIncrementalMarking.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1089533002: Abort incremental marking in test-heap/WeakCellsWithIncrementalMarking. (Closed)

Created:
5 years, 8 months ago by Yang

Modified:
5 years, 8 months ago

Reviewers:
ulan

CC:
v8-dev, Hannes Payer (out of office)

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Abort incremental marking in test-heap/WeakCellsWithIncrementalMarking. R=ulan@chromium.org Committed: https://crrev.com/d96224e8586df42a89cb36e62314f7e1a402321e Cr-Commit-Position: refs/heads/master@{#27838}

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	test/cctest/test-heap.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (1 generated)

Yang

This fixes the issue exposed in https://codereview.chromium.org/1088863002/

5 years, 8 months ago (2015-04-15 09:34:28 UTC) #1

ulan

lgtm, let's land it to fix the tree. Hannes, you'll get one simple merge conflict ...

5 years, 8 months ago (2015-04-15 09:36:44 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1089533002/1

5 years, 8 months ago (2015-04-15 09:38:13 UTC) #4

commit-bot: I haz the power

5 years, 8 months ago (2015-04-15 10:08:45 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/d96224e8586df42a89cb36e62314f7e1a402321e
Cr-Commit-Position: refs/heads/master@{#27838}