Source/modules/screen_orientation/ScreenOrientationController.h - Issue 1089523002: ScreenOrientationController: task-based dispatching of change events.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/screen_orientation/ScreenOrientationController.h

Issue 1089523002: ScreenOrientationController: task-based dispatching of change events. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/screen_orientation/page-visibility.html ('k') | Source/modules/screen_orientation/ScreenOrientationController.cpp » ('j') | Source/modules/screen_orientation/ScreenOrientationController.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/screen_orientation/ScreenOrientationController.h

diff --git a/Source/modules/screen_orientation/ScreenOrientationController.h b/Source/modules/screen_orientation/ScreenOrientationController.h

index 584dbb24172ed0f8e825bf530b35cc3f96329226..78915cc0594470e57add8310a1736273fbeae22e 100644

--- a/Source/modules/screen_orientation/ScreenOrientationController.h

+++ b/Source/modules/screen_orientation/ScreenOrientationController.h

@@ -8,7 +8,6 @@

#include "core/frame/LocalFrameLifecycleObserver.h"

#include "core/frame/PlatformEventController.h"

#include "platform/Supplementable.h"

-#include "platform/Timer.h"

#include "public/platform/WebLockOrientationCallback.h"

#include "public/platform/WebScreenOrientationLockType.h"

#include "public/platform/WebScreenOrientationType.h"

@@ -60,13 +59,13 @@ private:

void updateOrientation();

- void dispatchEventTimerFired(Timer<ScreenOrientationController>*);

+ void dispatchChangeEvent();

bool isActiveAndVisible() const;

PersistentWillBeMember<ScreenOrientation> m_orientation;

WebScreenOrientationClient* m_client;

- Timer<ScreenOrientationController> m_dispatchEventTimer;

+ bool m_isDispatchingEvent;

};

} // namespace blink