Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1854)

Unified Diff: content/shell/renderer/test_runner/web_ax_object_proxy.cc

Issue 1089503002: Removed depracated methods selectedTextRange and insertionPointLineNumber from accessibility API in… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/shell/renderer/test_runner/web_ax_object_proxy.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/shell/renderer/test_runner/web_ax_object_proxy.cc
diff --git a/content/shell/renderer/test_runner/web_ax_object_proxy.cc b/content/shell/renderer/test_runner/web_ax_object_proxy.cc
index 019f6415ce7550d7f29da85cc7a90e009f8f0b66..bfd8b01ecbd368340383297ae3fd85b9ada312e0 100644
--- a/content/shell/renderer/test_runner/web_ax_object_proxy.cc
+++ b/content/shell/renderer/test_runner/web_ax_object_proxy.cc
@@ -492,9 +492,6 @@ WebAXObjectProxy::GetObjectTemplateBuilder(v8::Isolate* isolate) {
&WebAXObjectProxy::SelectionStartLineNumber)
.SetProperty("selectionEndLineNumber",
&WebAXObjectProxy::SelectionEndLineNumber)
- .SetProperty("insertionPointLineNumber",
- &WebAXObjectProxy::InsertionPointLineNumber)
- .SetProperty("selectedTextRange", &WebAXObjectProxy::SelectedTextRange)
.SetProperty("isEnabled", &WebAXObjectProxy::IsEnabled)
.SetProperty("isRequired", &WebAXObjectProxy::IsRequired)
.SetProperty("isFocused", &WebAXObjectProxy::IsFocused)
@@ -741,23 +738,6 @@ int WebAXObjectProxy::SelectionEndLineNumber() {
return accessibility_object_.selectionEndLineNumber();
}
-// TODO(nektar): Remove this function after updating tests.
-int WebAXObjectProxy::InsertionPointLineNumber() {
- accessibility_object_.updateLayoutAndCheckValidity();
- if (!accessibility_object_.isFocused())
- return -1;
- return accessibility_object_.selectionEndLineNumber();
-}
-
-// TODO(nektar): Remove this function after updating tests.
-std::string WebAXObjectProxy::SelectedTextRange() {
- accessibility_object_.updateLayoutAndCheckValidity();
- unsigned selection_start = accessibility_object_.selectionStart();
- unsigned selection_end = accessibility_object_.selectionEnd();
- return base::StringPrintf("{%d, %d}",
- selection_start, selection_end - selection_start);
-}
-
bool WebAXObjectProxy::IsEnabled() {
accessibility_object_.updateLayoutAndCheckValidity();
return accessibility_object_.isEnabled();
« no previous file with comments | « content/shell/renderer/test_runner/web_ax_object_proxy.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698