[Webapp Refactor] Re-add remoting.ConnectionStats.

remoting/webapp/app_remoting/js/application_context_menu.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * Class representing the application's context menu.
  */
 
 'use strict';
 
 /** @suppress {duplicate} */
 var remoting = remoting || {};
 
 /**
  * @param {remoting.ContextMenuAdapter} adapter
+ * @param {remoting.ClientPlugin} plugin
  * @constructor
  */
-remoting.ApplicationContextMenu = function(adapter) {
+remoting.ApplicationContextMenu = function(adapter, plugin) {
   /** @private {remoting.ContextMenuAdapter} */
   this.adapter_ = adapter;
 
   this.adapter_.create(
       remoting.ApplicationContextMenu.kSendFeedbackId,
       l10n.getTranslationOrError(/*i18n-content*/'SEND_FEEDBACK'),
       false);
   this.adapter_.create(
       remoting.ApplicationContextMenu.kShowStatsId,
       l10n.getTranslationOrError(/*i18n-content*/'SHOW_STATS'),
       true);
+
+  // TODO(kelvinp):Unhook this event on shutdown.

[Jamie, 2015/04/15 17:02:47]

I don't think this is necessary. If an in-DOM context menu is being used, then
it will naturally disappear when the app quits. If it's a real context menu (on
ChromeOS), then the background page is responsible for cleaning up menu entries
when the app quits.

[kelvinp, 2015/04/15 18:37:50]

I think we should still clean up event listeners on destruction.  Currently
things work because we are running on the assumption that once a session
finishes, the app will quite, which may no longer be the case if we ended up
implementing reconnect. 

[Jamie, 2015/04/15 18:40:47]

Acknowledged.

   this.adapter_.addListener(this.onClicked_.bind(this));
 
   /** @private {string} */
   this.hostId_ = '';
+
+  /** @private */
+  this.stats_ = new remoting.ConnectionStats(
+      document.getElementById('statistics'), plugin);

[Jamie, 2015/04/15 17:02:47]

You're never calling dispose() on this. Does that matter?

[kelvinp, 2015/04/15 18:37:50]

Good catch. Done.

 };
 
 /**
  * @param {string} hostId
  */
 remoting.ApplicationContextMenu.prototype.setHostId = function(hostId) {
   this.hostId_ = hostId;
-}
+};
 
 /**
  * Add an indication of the connection RTT to the 'Show statistics' menu item.
  *
  * @param {number} rttMs The RTT of the connection, in ms.
  */
 remoting.ApplicationContextMenu.prototype.updateConnectionRTT =
     function(rttMs) {
   var rttText =
       rttMs < 50  ? /*i18n-content*/'CONNECTION_QUALITY_GOOD' :
@@ skipping 32 matching lines @@
           };
           consentWindow.contentWindow.postMessage(message, '*');
         };
         consentWindow.contentWindow.addEventListener('load', onLoad, false);
       };
       chrome.app.window.create(
           'feedback_consent.html', windowAttributes, onCreate);
       break;
 
     case remoting.ApplicationContextMenu.kShowStatsId:
-      if (remoting.stats) {
-        remoting.stats.show(info.checked);
-      }
+      this.stats_.show(info.checked);
       break;
   }
 };
 
 
 /** @type {string} */
 remoting.ApplicationContextMenu.kSendFeedbackId = 'send-feedback';
 
 /** @type {string} */
 remoting.ApplicationContextMenu.kShowStatsId = 'show-stats';