[Webapp Refactor] Re-add remoting.ConnectionStats.

[Webapp Refactor] Re-add remoting.ConnectionStats.

The ability to show ConnectionStats is accidentally removed in a
previous revision (https://crrev.com/1050ee48b1d8fe353bfc7df3b0ea4e5300260f5c).

This CL adds it back with the following additional changes:
1. Instead of having a global remoting.stats, remoting.ConnectionStats is now
   owned by ApplicationContextMenu in app remoting and DesktopConnectedView in
   deskop remoting.
2. Adds the show statistics functionality to desktop remoting.

BUG=476132
Committed: https://crrev.com/7e9210775408e18b8d6c7fc279bd81169c9d8856
Cr-Commit-Position: refs/heads/master@{#325327}

[kelvinp, 2015-04-15 03:56:18]

kelvinp@chromium.org changed reviewers:
+ jamiewalch@chromium.org

[kelvinp, 2015-04-15 03:57:14]

PTAL

[Jamie, 2015-04-15 17:02:47]

https://codereview.chromium.org/1089493002/diff/1/remoting/webapp/app_remotin...
File remoting/webapp/app_remoting/js/application_context_menu.js (right):

https://codereview.chromium.org/1089493002/diff/1/remoting/webapp/app_remotin...
remoting/webapp/app_remoting/js/application_context_menu.js:33: //
TODO(kelvinp):Unhook this event on shutdown.
I don't think this is necessary. If an in-DOM context menu is being used, then
it will naturally disappear when the app quits. If it's a real context menu (on
ChromeOS), then the background page is responsible for cleaning up menu entries
when the app quits.

https://codereview.chromium.org/1089493002/diff/1/remoting/webapp/app_remotin...
remoting/webapp/app_remoting/js/application_context_menu.js:41:
document.getElementById('statistics'), plugin);
You're never calling dispose() on this. Does that matter?

[kelvinp, 2015-04-15 18:37:50]

PTAL

https://codereview.chromium.org/1089493002/diff/1/remoting/webapp/app_remotin...
File remoting/webapp/app_remoting/js/application_context_menu.js (right):

https://codereview.chromium.org/1089493002/diff/1/remoting/webapp/app_remotin...
remoting/webapp/app_remoting/js/application_context_menu.js:33: //
TODO(kelvinp):Unhook this event on shutdown.
On 2015/04/15 17:02:47, Jamie wrote:
> I don't think this is necessary. If an in-DOM context menu is being used, then
> it will naturally disappear when the app quits. If it's a real context menu
(on
> ChromeOS), then the background page is responsible for cleaning up menu
entries
> when the app quits.

I think we should still clean up event listeners on destruction.  Currently
things work because we are running on the assumption that once a session
finishes, the app will quite, which may no longer be the case if we ended up
implementing reconnect.

https://codereview.chromium.org/1089493002/diff/1/remoting/webapp/app_remotin...
remoting/webapp/app_remoting/js/application_context_menu.js:41:
document.getElementById('statistics'), plugin);
On 2015/04/15 17:02:47, Jamie wrote:
> You're never calling dispose() on this. Does that matter?

Good catch. Done.

[Jamie, 2015-04-15 18:40:48]

lgtm

https://codereview.chromium.org/1089493002/diff/1/remoting/webapp/app_remotin...
File remoting/webapp/app_remoting/js/application_context_menu.js (right):

https://codereview.chromium.org/1089493002/diff/1/remoting/webapp/app_remotin...
remoting/webapp/app_remoting/js/application_context_menu.js:33: //
TODO(kelvinp):Unhook this event on shutdown.
On 2015/04/15 18:37:50, kelvinp wrote:
> On 2015/04/15 17:02:47, Jamie wrote:
> > I don't think this is necessary. If an in-DOM context menu is being used,
then
> > it will naturally disappear when the app quits. If it's a real context menu
> (on
> > ChromeOS), then the background page is responsible for cleaning up menu
> entries
> > when the app quits.
> 
> I think we should still clean up event listeners on destruction.  Currently
> things work because we are running on the assumption that once a session
> finishes, the app will quite, which may no longer be the case if we ended up
> implementing reconnect. 

Acknowledged.

[kelvinp, 2015-04-15 21:03:36]

The CQ bit was checked by kelvinp@chromium.org

[commit-bot: I haz the power, 2015-04-15 21:06:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1089493002/20001

[commit-bot: I haz the power, 2015-04-15 22:29:22]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-04-15 22:31:02]

Patchset 2 (id:??) landed as
https://crrev.com/7e9210775408e18b8d6c7fc279bd81169c9d8856
Cr-Commit-Position: refs/heads/master@{#325327}