Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Side by Side Diff: Source/core/inspector/InspectorDebuggerAgent.cpp

Issue 1089463005: Devtools: Fix "EventListeners don't work after timeline" (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Test added Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « LayoutTests/inspector/sources/debugger/event-listener-breakpoints-after-suspension-expected.txt ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2010 Apple Inc. All rights reserved.
3 * Copyright (C) 2013 Google Inc. All rights reserved. 3 * Copyright (C) 2013 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 8 *
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 170 matching lines...) Expand 10 before | Expand all | Expand 10 after
181 } 181 }
182 182
183 void InspectorDebuggerAgent::enable() 183 void InspectorDebuggerAgent::enable()
184 { 184 {
185 m_instrumentingAgents->setInspectorDebuggerAgent(this); 185 m_instrumentingAgents->setInspectorDebuggerAgent(this);
186 186
187 startListeningScriptDebugServer(); 187 startListeningScriptDebugServer();
188 // FIXME(WK44513): breakpoints activated flag should be synchronized between all front-ends 188 // FIXME(WK44513): breakpoints activated flag should be synchronized between all front-ends
189 scriptDebugServer().setBreakpointsActivated(true); 189 scriptDebugServer().setBreakpointsActivated(true);
190 190
191 m_state->setBoolean(DebuggerAgentState::debuggerEnabled, true);
191 if (m_listener) 192 if (m_listener)
192 m_listener->debuggerWasEnabled(); 193 m_listener->debuggerWasEnabled();
193 } 194 }
194 195
195 void InspectorDebuggerAgent::disable() 196 void InspectorDebuggerAgent::disable()
196 { 197 {
197 m_state->setObject(DebuggerAgentState::javaScriptBreakpoints, JSONObject::cr eate()); 198 m_state->setObject(DebuggerAgentState::javaScriptBreakpoints, JSONObject::cr eate());
198 m_state->setLong(DebuggerAgentState::pauseOnExceptionsState, ScriptDebugServ er::DontPauseOnExceptions); 199 m_state->setLong(DebuggerAgentState::pauseOnExceptionsState, ScriptDebugServ er::DontPauseOnExceptions);
199 m_state->setString(DebuggerAgentState::skipStackPattern, ""); 200 m_state->setString(DebuggerAgentState::skipStackPattern, "");
200 m_state->setBoolean(DebuggerAgentState::skipContentScripts, false); 201 m_state->setBoolean(DebuggerAgentState::skipContentScripts, false);
(...skipping 14 matching lines...) Expand all
215 { 216 {
216 return m_state->getBoolean(DebuggerAgentState::debuggerEnabled); 217 return m_state->getBoolean(DebuggerAgentState::debuggerEnabled);
217 } 218 }
218 219
219 void InspectorDebuggerAgent::enable(ErrorString*) 220 void InspectorDebuggerAgent::enable(ErrorString*)
220 { 221 {
221 if (enabled()) 222 if (enabled())
222 return; 223 return;
223 224
224 enable(); 225 enable();
225 m_state->setBoolean(DebuggerAgentState::debuggerEnabled, true);
226 226
227 ASSERT(frontend()); 227 ASSERT(frontend());
228 } 228 }
229 229
230 void InspectorDebuggerAgent::disable(ErrorString*) 230 void InspectorDebuggerAgent::disable(ErrorString*)
231 { 231 {
232 if (!enabled()) 232 if (!enabled())
233 return; 233 return;
234 234
235 disable(); 235 disable();
(...skipping 1401 matching lines...) Expand 10 before | Expand all | Expand 10 after
1637 visitor->trace(m_v8AsyncCallTracker); 1637 visitor->trace(m_v8AsyncCallTracker);
1638 visitor->trace(m_promiseTracker); 1638 visitor->trace(m_promiseTracker);
1639 visitor->trace(m_asyncOperations); 1639 visitor->trace(m_asyncOperations);
1640 visitor->trace(m_currentAsyncCallChain); 1640 visitor->trace(m_currentAsyncCallChain);
1641 visitor->trace(m_asyncCallTrackingListeners); 1641 visitor->trace(m_asyncCallTrackingListeners);
1642 #endif 1642 #endif
1643 InspectorBaseAgent::trace(visitor); 1643 InspectorBaseAgent::trace(visitor);
1644 } 1644 }
1645 1645
1646 } // namespace blink 1646 } // namespace blink
OLDNEW
« no previous file with comments | « LayoutTests/inspector/sources/debugger/event-listener-breakpoints-after-suspension-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698