Do not use erroneouselement unless the member is static

pkg/compiler/lib/src/resolution/members.dart

Index: pkg/compiler/lib/src/resolution/members.dart
diff --git a/pkg/compiler/lib/src/resolution/members.dart b/pkg/compiler/lib/src/resolution/members.dart
index b9d2abda17880060291d3a1056589c1ec3bd85af..4d7b3d71175179316282e4c152de328031b401e9 100644
--- a/pkg/compiler/lib/src/resolution/members.dart
+++ b/pkg/compiler/lib/src/resolution/members.dart
@@ -3012,14 +3012,24 @@ class ResolverVisitor extends MappingVisitor<ResolutionResult> {
             MessageKind.ASSIGNING_TYPE, const {});
         registry.registerThrowNoSuchMethod();
       } else if (target.isFinal || target.isConst) {
-        setter = reportAndCreateErroneousElement(
+        if (Elements.isStaticOrTopLevelField(target)) {

[Harry Terkelsen, 2015/04/15 18:22:34]

this check causes this to print '2':

class A {
  foo() {
    final bar = 1;
    bar = 2;
    print(bar);
  }
}
main() => new A().foo();

[Siggi Cherem (dart-lang), 2015/04/15 22:39:46]

Good catch Harry, this should also test for isLocal like I was doing below with
the local functions.

I added it here and added some tests for the warnings.

+          setter = reportAndCreateErroneousElement(
               node.selector, target.name, MessageKind.CANNOT_RESOLVE_SETTER,
               const {});
+        } else {
+          compiler.reportWarning(node.selector,
+              MessageKind.CANNOT_RESOLVE_SETTER);
+        }
         registry.registerThrowNoSuchMethod();
       } else if (target.isFunction && target.name != '[]=') {
         assert(!target.isSetter);
-        setter = reportAndCreateErroneousElement(
-            node.selector, target.name, MessageKind.ASSIGNING_METHOD, const {});
+        if (Elements.isStaticOrTopLevelFunction(target) || target.isLocal) {
+          setter = reportAndCreateErroneousElement(
+              node.selector, target.name, MessageKind.ASSIGNING_METHOD,
+              const {});
+        } else {
+          compiler.reportWarning(node.selector, MessageKind.ASSIGNING_METHOD);
+        }
         registry.registerThrowNoSuchMethod();
         if (node.isSuperCall) registry.registerSuperNoSuchMethod();
       }