Do not use erroneouselement unless the member is static

pkg/compiler/lib/src/resolution/members.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of resolution;
 
 abstract class TreeElements {
   AnalyzableElement get analyzedElement;
   Iterable<Node> get superUses;
 
@@ skipping 2994 matching lines @@
         if (isComplex && getter == null && !inInstanceContext) {
           getter = reportAndCreateErroneousElement(node.selector, field.name,
               MessageKind.CANNOT_RESOLVE_GETTER, const {});
           registry.registerThrowNoSuchMethod();
         }
       } else if (target.impliesType) {
         setter = reportAndCreateErroneousElement(node.selector, target.name,
             MessageKind.ASSIGNING_TYPE, const {});
         registry.registerThrowNoSuchMethod();
       } else if (target.isFinal || target.isConst) {
-        setter = reportAndCreateErroneousElement(
+        if (Elements.isStaticOrTopLevelField(target) || target.isLocal) {
+          setter = reportAndCreateErroneousElement(
               node.selector, target.name, MessageKind.CANNOT_RESOLVE_SETTER,
               const {});
+        } else {
+          // For instance fields we don't report a warning here because the type
+          // checker will detect this as well and report a better error message
+          // with the context of the containing class.
+        }
         registry.registerThrowNoSuchMethod();
+        if (node.isSuperCall) registry.registerSuperNoSuchMethod();

[Johnni Winther, 2015/04/16 07:41:05]

This case should create an ErrenousElement since the call isn't using dynamic
dispatch. The SSA backend probably detects this case (I guess we have tests for
it) but it should have been told to produce the NSM.

[Siggi Cherem (dart-lang), 2015/04/16 15:49:44]

Interesting - I'll create a follow up CL with this (I submitted this one
yesterday).

Would that be true also when the "this" receiver is explicit
(node.receiver.isThis())?

[Siggi Cherem (dart-lang), 2015/04/16 19:58:15]

I tried this out, but I think this makes the errror message for `super.x` a bit
worse. It makes us report the error here (cannot-resolve-setter or
assigning-method) rather than the typechecker error (setter-not-found-in-class)
which includes the class where we are looking up the member. (see
https://codereview.chromium.org/1090923004 for the tentative change).

Thoughts?

       } else if (target.isFunction && target.name != '[]=') {
         assert(!target.isSetter);
-        setter = reportAndCreateErroneousElement(
-            node.selector, target.name, MessageKind.ASSIGNING_METHOD, const {});
+        if (Elements.isStaticOrTopLevelFunction(target) || target.isLocal) {
+          setter = reportAndCreateErroneousElement(
+              node.selector, target.name, MessageKind.ASSIGNING_METHOD,
+              const {});
+        } else {
+          // For instance methods we don't report a warning here because the
+          // type checker will detect this as well and report a better error
+          // message with the context of the containing class.
+        }
         registry.registerThrowNoSuchMethod();
         if (node.isSuperCall) registry.registerSuperNoSuchMethod();
       }
       if (isPotentiallyMutableTarget(target)) {
         registry.registerPotentialMutation(target, node);
         if (enclosingElement != target.enclosingElement) {
           registry.registerPotentialMutationInClosure(target, node);
         }
         for (Node scope in promotionScope) {
           registry.registerPotentialMutationIn(scope, target, node);
@@ skipping 2078 matching lines @@
 }
 
 /// The result for the resolution of the `assert` method.
 class AssertResult implements ResolutionResult {
   const AssertResult();
 
   Element get element => null;
 
   String toString() => 'AssertResult()';
 }