Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1205)

Unified Diff: pkg/analysis_server/test/mocks.dart

Issue 1089453002: Avoid redundant calls to "pub list" when multiple dependencies change. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Add missing source file. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/mocks.dart
diff --git a/pkg/analysis_server/test/mocks.dart b/pkg/analysis_server/test/mocks.dart
index be1473234d5cec806c2b2f79cf83c315c6dcc2ee..94bc8c6f21e6431a19ba9a88ed9846803e150833 100644
--- a/pkg/analysis_server/test/mocks.dart
+++ b/pkg/analysis_server/test/mocks.dart
@@ -14,6 +14,7 @@ import 'package:analysis_server/src/channel/channel.dart';
import 'package:analysis_server/src/operation/operation.dart';
import 'package:analysis_server/src/operation/operation_analysis.dart';
import 'package:analysis_server/src/protocol.dart' hide Element, ElementKind;
+import 'package:analysis_server/src/source/optimizing_pub_package_map_provider.dart';
import 'package:analyzer/file_system/file_system.dart' as resource;
import 'package:analyzer/file_system/memory_file_system.dart' as resource;
import 'package:analyzer/source/package_map_provider.dart';
@@ -152,7 +153,7 @@ class MockMethodElement extends StringTypedMock implements MethodElement {
/**
* A mock [PackageMapProvider].
*/
-class MockPackageMapProvider implements PackageMapProvider {
+class MockPackageMapProvider implements OptimizingPubPackageMapProvider {
/**
* Package map that will be returned by the next call to [computePackageMap].
*/
@@ -169,12 +170,42 @@ class MockPackageMapProvider implements PackageMapProvider {
*/
Set<String> dependencies = new Set<String>();
+ /**
+ * Modification times that will be returned by the next call to
+ * [computePackageMap]. This will be filtered to include only those paths
+ * mentioned in the `dependencies` field of [computePackageMap]'s
+ * `previousInfo` argument.
+ */
+ Map<String, int> modificationTimes = <String, int>{};
+
+ /**
+ * Number of times [computePackageMap] has been called.
+ */
+ int computeCount = 0;
+
@override
- PackageMapInfo computePackageMap(resource.Folder folder) {
+ OptimizingPubPackageMapInfo computePackageMap(resource.Folder folder,
+ [OptimizingPubPackageMapInfo previousInfo]) {
+ ++computeCount;
+ Map<String, int> filteredModificationTimes = <String, int>{};
+ if (previousInfo != null) {
+ for (String dependency in previousInfo.dependencies) {
+ if (modificationTimes.containsKey(dependency)) {
+ filteredModificationTimes[dependency] = modificationTimes[dependency];
+ }
+ }
+ }
if (packageMaps != null) {
- return new PackageMapInfo(packageMaps[folder.path], dependencies);
+ return new OptimizingPubPackageMapInfo(
+ packageMaps[folder.path], dependencies, filteredModificationTimes);
}
- return new PackageMapInfo(packageMap, dependencies);
+ return new OptimizingPubPackageMapInfo(
+ packageMap, dependencies, filteredModificationTimes);
+ }
+
+ noSuchMethod(Invocation invocation) {
+ // No other methods should be called.
+ return super.noSuchMethod(invocation);
}
}

Powered by Google App Engine
This is Rietveld 408576698