pkg/analysis_server/lib/src/source/caching_pub_package_map_provider.dart - Issue 1089453002: Avoid redundant calls to "pub list" when multiple dependencies change.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/source/caching_pub_package_map_provider.dart

Issue 1089453002: Avoid redundant calls to "pub list" when multiple dependencies change. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Add missing source file. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/socket_server.dart ('k') | pkg/analysis_server/lib/src/source/optimizing_pub_package_map_provider.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/source/caching_pub_package_map_provider.dart

diff --git a/pkg/analysis_server/lib/src/source/caching_pub_package_map_provider.dart b/pkg/analysis_server/lib/src/source/caching_pub_package_map_provider.dart

index e6d0d591fece9169c33220e0a3bc1eeddd21295c..f6c9bb7da3cfd00154a66eda7a1da34a2d7ac109 100644

--- a/pkg/analysis_server/lib/src/source/caching_pub_package_map_provider.dart

+++ b/pkg/analysis_server/lib/src/source/caching_pub_package_map_provider.dart

@@ -24,6 +24,9 @@ typedef int WriteFile(File file, String content);

* [PubPackageMapProvider] extension which caches pub list results.

* These results are cached in memory and in a single place on disk that is

* shared cross session and between different simultaneous sessions.

+ *

+ * TODO(paulberry): before this class is used again, it should be ported over

+ * to extend OptimizingPubPackageMapProvider instead of PubPackageMapProvider.

class CachingPubPackageMapProvider extends PubPackageMapProvider {

static const cacheKey = 'pub_list_cache';