Issue 1089443003: Revert of Created new URLRequestContext for secure proxy check

Issue 1089443003: Revert of Created new URLRequestContext for secure proxy check (Closed)

Created:
5 years, 8 months ago by gone

Modified:
5 years, 8 months ago

Reviewers:
sgurun-gerrit only, sclittle, Ryan Hamilton, bengr, jeremyim, mmenke, tbansal1

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Revert of Created new URLRequestContext for secure proxy check (patchset #20 id:380001 of https://codereview.chromium.org/981633002/) Reason for revert: This is breaking all the tests again: http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/27288/ Original issue's description: > Created new URLRequestContext for secure proxy check. > > The new URLRequestContext disables alternate protocols > to ensure that the Data Reduction Proxy secure proxy check > request goes out over vanilla HTTP so that it can be > intercepted by middleboxes. > > Also, secure proxy check is now done on IO thread. > > BUG=437080 > > Committed: https://crrev.com/652eabf1141c00594aa6e9ed81beb980aec89198 > Cr-Commit-Position: refs/heads/master@{#325302} > > Committed: https://crrev.com/afc53166cb6a0ed561f416403ab68261eae4427b > Cr-Commit-Position: refs/heads/master@{#325464} TBR=sclittle@chromium.org,rch@chromium.org,bengr@chromium.org,mmenke@chromium.org,sgurun@chromium.org,jeremyim@chromium.org,tbansal@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=437080 Committed: https://crrev.com/4e2fe1e46f1150523f237680a2b9656b2c9b7b29 Cr-Commit-Position: refs/heads/master@{#325526}

Created: 5 years, 8 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+147 lines, -156 lines)			Patch
M	components/data_reduction_proxy/core/browser/data_reduction_proxy_config.h	View	9 chunks	+18 lines, -17 lines	0 comments	Download
M	components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc	View	7 chunks	+38 lines, -112 lines	0 comments	Download
M	components/data_reduction_proxy/core/browser/data_reduction_proxy_config_test_utils.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	components/data_reduction_proxy/core/browser/data_reduction_proxy_config_test_utils.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc	View	2 chunks	+6 lines, -3 lines	0 comments	Download
M	components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.cc	View	2 chunks	+6 lines, -5 lines	0 comments	Download
M	components/data_reduction_proxy/core/browser/data_reduction_proxy_service.h	View	6 chunks	+28 lines, -2 lines	0 comments	Download
M	components/data_reduction_proxy/core/browser/data_reduction_proxy_service.cc	View	2 chunks	+46 lines, -0 lines	0 comments	Download
M	components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc	View	1 chunk	+0 lines, -12 lines	0 comments	Download
M	components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	net/url_request/url_request_test_util.h	View	1 chunk	+1 line, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

gone

Created Revert of Created new URLRequestContext for secure proxy check

5 years, 8 months ago (2015-04-16 22:23:09 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1089443003/1

5 years, 8 months ago (2015-04-16 22:25:44 UTC) #2

commit-bot: I haz the power

5 years, 8 months ago (2015-04-16 22:30:27 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/4e2fe1e46f1150523f237680a2b9656b2c9b7b29
Cr-Commit-Position: refs/heads/master@{#325526}