Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 1089393004: Let asan imply clang and use_allocator=none. (Closed)

Created:
5 years, 8 months ago by Michael Achenbach
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Let asan imply clang and use_allocator=none. BUG= Committed: https://crrev.com/f61f521d70cde564a38ada758ffa415d82f0464e Cr-Commit-Position: refs/heads/master@{#27905}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M build/standalone.gypi View 1 3 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Achenbach
PTAL. Somehow, the default values in toolchain.gypi are not enough. I assume/hope this will not ...
5 years, 8 months ago (2015-04-16 13:51:12 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 8 months ago (2015-04-16 14:46:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1089393004/2
5 years, 8 months ago (2015-04-17 08:12:03 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:2)
5 years, 8 months ago (2015-04-17 08:13:24 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-17 08:13:36 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f61f521d70cde564a38ada758ffa415d82f0464e
Cr-Commit-Position: refs/heads/master@{#27905}

Powered by Google App Engine
This is Rietveld 408576698