Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Unified Diff: components/test/data/password_manager/automated_tests/environment.py

Issue 1089383002: [Password manager tests automation] Refactor test_runner. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@base
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/test/data/password_manager/automated_tests/run_tests.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/test/data/password_manager/automated_tests/environment.py
diff --git a/components/test/data/password_manager/automated_tests/environment.py b/components/test/data/password_manager/automated_tests/environment.py
index fd52754e3b6f496511dca781c3adb8fbb4a355aa..3743465043ecce0ab5f6406774b6206e0215058b 100644
--- a/components/test/data/password_manager/automated_tests/environment.py
+++ b/components/test/data/password_manager/automated_tests/environment.py
@@ -288,7 +288,12 @@ class Environment:
getattr(websitetest, test_case_name)()
except Exception as e:
successful = False
- error = e.message
+ # httplib.CannotSendRequest doesn't define a message,
+ # so type(e).__name__ will at least log exception name as a reason.
+ # TODO(melandory): logging.exception(e) produces meaningful result
+ # for httplib.CannotSendRequest, so we can try to propagate information
+ # that reason is an exception to the logging phase.
+ error = "Exception %s %s" % (type(e).__name__, e)
self.tests_results.append(
(websitetest.name, test_case_name, successful, error))
« no previous file with comments | « no previous file | components/test/data/password_manager/automated_tests/run_tests.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698