HLoadKeyed for Smis optimized for x64

src/x64/lithium-codegen-x64.cc

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 3035 matching lines @@
       instr->elements(),
       key,
       FAST_DOUBLE_ELEMENTS,
       FixedDoubleArray::kHeaderSize - kHeapObjectTag,
       instr->additional_index());
   __ movsd(result, double_load_operand);
 }
 
 
 void LCodeGen::DoLoadKeyedFixedArray(LLoadKeyed* instr) {
+  HLoadKeyed* hinstr = instr->hydrogen();
   Register result = ToRegister(instr->result());
   LOperand* key = instr->key();
   if (!key->IsConstantOperand()) {
     Register key_reg = ToRegister(key);
     // Even though the HLoad/StoreKeyedFastElement instructions force
     // the input representation for the key to be an integer, the input
     // gets replaced during bound check elimination with the index
     // argument to the bounds check, which can be tagged, so that
     // case must be handled here, too.
-    if (instr->hydrogen()->IsDehoisted()) {
+    if (hinstr->IsDehoisted()) {
       // Sign extend key because it could be a 32 bit negative value
       // and the dehoisted address computation happens in 64 bits
       __ movsxlq(key_reg, key_reg);
     }
   }
 
-  // Load the result.
-  __ movq(result,
+  bool requires_hole_check = hinstr->RequiresHoleCheck();
+  int offs = FixedArray::kHeaderSize - kHeapObjectTag;

[Toon Verwaest, 2013/12/09 13:47:23]

Please write out variable names: "offset".

[Igor Sheludko, 2013/12/09 17:27:06]

Done.

+  Representation representation = hinstr->representation();
+
+  if (hinstr->type().IsSmi() && representation.IsInteger32()) {

[Toon Verwaest, 2013/12/09 13:47:23]

Why check for hinstr->type().IsSmi()? You should only get to
representation.IsInteger32() if you converted a smi-load into an int32 load.

[Igor Sheludko, 2013/12/09 17:27:06]

We can't rely only on IsInteger32() case since we can get an int32
representation for external arrays. We dicussed this and decided that it is
better to check elements' kind against FAST_SMI_ELEMENTS.

+    ASSERT(!requires_hole_check);
+    // Read int value directly from upper half of the smi.
+    offs += kPointerSize / 2;

[Toon Verwaest, 2013/12/09 13:47:23]

Isn't there a kSmiTagSize you can use? You just want to jump over the smi-tag.

[Igor Sheludko, 2013/12/09 17:27:06]

kSmiTagSize is a number of bits, so we can't use it here, but I'll add an assert
instead:
STATIC_ASSERT(kSmiTagSize + kSmiShiftSize == 32);

+  }
+
+  __ Load(result,
           BuildFastArrayOperand(instr->elements(),
                                 key,
                                 FAST_ELEMENTS,
-                                FixedArray::kHeaderSize - kHeapObjectTag,
-                                instr->additional_index()));
+                                offs,
+                                instr->additional_index()),
+          representation);
 
   // Check for the hole value.
-  if (instr->hydrogen()->RequiresHoleCheck()) {
-    if (IsFastSmiElementsKind(instr->hydrogen()->elements_kind())) {
+  if (requires_hole_check) {
+    if (IsFastSmiElementsKind(hinstr->elements_kind())) {
       Condition smi = __ CheckSmi(result);
       DeoptimizeIf(NegateCondition(smi), instr->environment());
     } else {
       __ CompareRoot(result, Heap::kTheHoleValueRootIndex);
       DeoptimizeIf(equal, instr->environment());
     }
   }
 }
 
 
@@ skipping 2489 matching lines @@
                                FixedArray::kHeaderSize - kPointerSize));
   __ bind(&done);
 }
 
 
 #undef __
 
 } }  // namespace v8::internal
 
 #endif  // V8_TARGET_ARCH_X64