Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 1089303003: Migrate error messages, part 3 (runtime.js). (Closed)

Created:
5 years, 8 months ago by Yang
Modified:
5 years, 8 months ago
Reviewers:
mvstanton
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Migrate error messages, part 3 (runtime.js). Motivation for this is reducing the size of the native context. R=mvstanton@chromium.org Committed: https://crrev.com/5a9a0b20e74b1ffc88141fe3e86a1df6d6773685 Cr-Commit-Position: refs/heads/master@{#27917}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -54 lines) Patch
M src/messages.h View 1 chunk +18 lines, -0 lines 0 comments Download
M src/messages.js View 5 chunks +1 line, -15 lines 0 comments Download
M src/runtime.js View 18 chunks +21 lines, -28 lines 0 comments Download
M src/runtime/runtime-object.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M src/symbol.js View 1 chunk +1 line, -3 lines 0 comments Download
M test/mjsunit/messages.js View 3 chunks +80 lines, -1 line 0 comments Download
M tools/js2c.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Yang
5 years, 8 months ago (2015-04-17 11:27:04 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1089303003/1
5 years, 8 months ago (2015-04-17 11:30:26 UTC) #3
mvstanton
lgtm
5 years, 8 months ago (2015-04-17 13:25:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1089303003/1
5 years, 8 months ago (2015-04-17 13:26:13 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-17 13:27:45 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-17 13:27:57 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5a9a0b20e74b1ffc88141fe3e86a1df6d6773685
Cr-Commit-Position: refs/heads/master@{#27917}

Powered by Google App Engine
This is Rietveld 408576698