Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2936)

Unified Diff: android_webview/crash_reporter/aw_microdump_crash_reporter.cc

Issue 1089303002: [android-webview] Disable breakpad microdumps on x86/64 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/crash_reporter/aw_microdump_crash_reporter.cc
diff --git a/android_webview/crash_reporter/aw_microdump_crash_reporter.cc b/android_webview/crash_reporter/aw_microdump_crash_reporter.cc
index 490cd9b7de7df929be54e441b5d5d16d774c861b..016288a9c672769c3e846a1a3c6ff3327c8addaa 100644
--- a/android_webview/crash_reporter/aw_microdump_crash_reporter.cc
+++ b/android_webview/crash_reporter/aw_microdump_crash_reporter.cc
@@ -5,6 +5,7 @@
#include "android_webview/crash_reporter/aw_microdump_crash_reporter.h"
#include "base/lazy_instance.h"
+#include "build/build_config.h"
#include "components/crash/app/breakpad_linux.h"
#include "components/crash/app/crash_reporter_client.h"
@@ -38,6 +39,13 @@ bool g_enabled = false;
} // namespace
void EnableMicrodumpCrashReporter() {
+#if defined(ARCH_CPU_X86_FAMILY)
+ // Don't install signal handler on X86/64 because this breaks binary
+ // translators that handle SIGSEGV in userspace and get chained after our
+ // handler. See crbug.com/477444
+ return;
+#endif
+
if (g_enabled) {
NOTREACHED() << "EnableMicrodumpCrashReporter called more than once";
return;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698