build/android/pylib/local/device/local_device_environment.py - Issue 1089273002: Revert of [Android] Remove android_commands uses from build/android/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/local/device/local_device_environment.py

Issue 1089273002: Revert of [Android] Remove android_commands uses from build/android/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/pylib/local/device/local_device_environment.py

diff --git a/build/android/pylib/local/device/local_device_environment.py b/build/android/pylib/local/device/local_device_environment.py

index 8346762371c03883cdac138ab17a7ae6b754d053..72acb6e2ec44e71ce1922b88225888035123a68d 100644

--- a/build/android/pylib/local/device/local_device_environment.py

+++ b/build/android/pylib/local/device/local_device_environment.py

@@ -5,7 +5,6 @@

from pylib.base import environment

from pylib.device import adb_wrapper

from pylib.device import device_errors

-from pylib.device import device_filter

from pylib.device import device_utils

from pylib.utils import parallelizer

@@ -21,8 +20,8 @@

#override

def SetUp(self):

- available_devices = adb_wrapper.AdbWrapper.Devices(

- filters=device_filter.DefaultFilters())

+ # TODO(jbudorick): This can be refined to support filters etc.

+ available_devices = adb_wrapper.AdbWrapper.GetDevices()

if not available_devices:

raise device_errors.NoDevicesError

if self._device:

« no previous file with comments | « build/android/pylib/device/device_utils_test.py ('k') | build/android/screenshot.py » ('j') | no next file with comments »