Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(785)

Issue 1089223003: Move all the page actions from repaint measurements to repaint pages. (Closed)

Created:
5 years, 8 months ago by nednguyen
Modified:
5 years, 8 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move all the page actions from repaint measurements to repaint pages. This is due to 2 reasons: + Page specific logic should belong to page, not page test. + Simplify the repaint measurement control code, which make it easier to port repaint to TimelineBasedMeasurement. Trybot link for repaint.gpu_rasterization.key_mobile_sites_repaint: https://codereview.chromium.org/1098543002 BUG=444703, 455391 Committed: https://crrev.com/fbd947210ecfb42637eca91ceef059f40eea9c0d Cr-Commit-Position: refs/heads/master@{#325558}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -73 lines) Patch
M tools/perf/benchmarks/repaint.py View 2 chunks +6 lines, -4 lines 0 comments Download
M tools/perf/measurements/repaint.py View 2 chunks +1 line, -39 lines 0 comments Download
M tools/perf/measurements/repaint_unittest.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/page_sets/key_mobile_sites_repaint.py View 5 chunks +30 lines, -21 lines 0 comments Download
A tools/perf/page_sets/repaint_helpers.py View 1 chunk +46 lines, -0 lines 0 comments Download
M tools/perf/page_sets/top_25_repaint.py View 4 chunks +17 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
nednguyen
5 years, 8 months ago (2015-04-16 21:08:31 UTC) #4
vmiura
LGTM
5 years, 8 months ago (2015-04-16 21:52:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1089223003/40001
5 years, 8 months ago (2015-04-16 22:42:51 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:40001)
5 years, 8 months ago (2015-04-16 23:59:03 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-17 00:01:10 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fbd947210ecfb42637eca91ceef059f40eea9c0d
Cr-Commit-Position: refs/heads/master@{#325558}

Powered by Google App Engine
This is Rietveld 408576698