Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 1089193002: Add chrome.fileManagerPrivate.getProvidingExtensions(). (Closed)

Created:
5 years, 8 months ago by mtomasz
Modified:
5 years, 8 months ago
Reviewers:
hirono, Ilya Sherman
CC:
chromium-reviews, extensions-reviews_chromium.org, asvitkine+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add chrome.fileManagerPrivate.getProvidingExtensions(). This method returns a list of installed providing extensions with extra flags saying whether the extension handles configuring or adding new mount points via an event. TEST=Not yet, they will be added in a follow up CL once all is wired up. BUG=474146 Committed: https://crrev.com/6cac9ef5b1487d39477e453d270de321d6db8b87 Cr-Commit-Position: refs/heads/master@{#325395}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -4 lines) Patch
M chrome/browser/chromeos/extensions/file_manager/private_api_misc.h View 2 chunks +17 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc View 2 chunks +33 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/service.h View 2 chunks +15 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/service.cc View 3 chunks +42 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/file_manager_private.idl View 3 chunks +21 lines, -0 lines 0 comments Download
M extensions/browser/extension_function_histogram_value.h View 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
mtomasz
@isherman: PTAL at histograms. @hirono: PTAL at everything else. Thanks.
5 years, 8 months ago (2015-04-15 07:07:41 UTC) #2
hirono
lgtm. Please update the master of closure compiler's externs. https://codereview.chromium.org/1089193002/diff/1/chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc File chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc (right): https://codereview.chromium.org/1089193002/diff/1/chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc#newcode467 chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc:467: ...
5 years, 8 months ago (2015-04-15 07:44:18 UTC) #3
Ilya Sherman
LGTM
5 years, 8 months ago (2015-04-15 20:50:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1089193002/20001
5 years, 8 months ago (2015-04-16 03:09:39 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-16 04:57:32 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 04:58:28 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6cac9ef5b1487d39477e453d270de321d6db8b87
Cr-Commit-Position: refs/heads/master@{#325395}

Powered by Google App Engine
This is Rietveld 408576698