Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1089173003: Revert of Mac Video Capture AVFoundation: Calculate compressed frame size for MJPEG. (Closed)

Created:
5 years, 8 months ago by magjed_chromium
Modified:
5 years, 8 months ago
CC:
oja_google.com, fbarchard, chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Mac Video Capture AVFoundation: Calculate compressed frame size for MJPEG. (patchset #2 id:20001 of https://codereview.chromium.org/912293005/) Reason for revert: An improved version of ValidateJpeg in libyuv has been rolled into chromium and this CL is no longer needed. Original issue's description: > Mac Video Capture AVFoundation: Calculate compressed frame size for MJPEG. > > The frame size we receive from AVFoundation is sometimes excessive, e.g. the size of the uncompressed frame. For example, for a JPEG YUV422, the reported size might be 1280*720*2 = 1.8MB, while the actual compressed data is only 260kB. > > In these cases, libyuv::MJPGToI420 spends a lot of time in libyuv::ValidateJpeg, as much as 25%. The reason for this is that ValidateJpeg starts at the end of the buffer and loops backwards looking for the End Of Image (EOI) marker. > > This CL tries to optimize these cases by finding the EOI by looping forwards instead of backwards, and reporting the actual frame size to libyuv::MJPGToI420. > > BUG=346634, 460497 > > Committed: https://crrev.com/dc556d2b54354adc95ee5474600f469f7ae65692 > Cr-Commit-Position: refs/heads/master@{#317333} TBR=perkj@chromium.org,mcasas@chromium.org,tommi@chromium.org,torbjorng@google.com,torbjorng@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=346634, 460497 Committed: https://crrev.com/0deddb9627adb0a4d473c6e0fdafa8e32062101e Cr-Commit-Position: refs/heads/master@{#325211}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -27 lines) Patch
M media/video/capture/mac/video_capture_device_avfoundation_mac.mm View 3 chunks +0 lines, -27 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
magjed_chromium
Created Revert of Mac Video Capture AVFoundation: Calculate compressed frame size for MJPEG.
5 years, 8 months ago (2015-04-15 08:30:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1089173003/1
5 years, 8 months ago (2015-04-15 08:32:23 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-15 08:33:20 UTC) #4
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 08:34:48 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0deddb9627adb0a4d473c6e0fdafa8e32062101e
Cr-Commit-Position: refs/heads/master@{#325211}

Powered by Google App Engine
This is Rietveld 408576698