Issue 1089163005: Make the keyboard reappear when you tap on a text field after having dismissed the keyboard.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1089163005: Make the keyboard reappear when you tap on a text field after having dismissed the keyboard. (Closed)

Created:
5 years, 8 months ago by Hixie

Modified:
5 years, 8 months ago

Reviewers:
eseidel

CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Make the keyboard reappear when you tap on a text field after having dismissed the keyboard. - the keyboard service now has a showByRequest() method that invokes Android's InputMethodManager's imm.showSoftInput with no flags set. - the Input component calls through to the keyboard service's showByRequest() when it receives a pointer down. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/ab0e7a5fb2339db49c7baadc341f137aff87c8e0

Patch Set 1 #

Patch Set 2 : Turns out you don't want the InputMethodManager.SHOW_FORCED flag set in this case. #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -4 lines)			Patch
M	mojo/services/keyboard/public/interfaces/keyboard.mojom	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	services/keyboard/org/chromium/mojo/keyboard/KeyboardServiceImpl.java	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
M	sky/framework/components/input.dart	View		2 chunks	+8 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Hixie

5 years, 8 months ago (2015-04-20 18:45:37 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
ab0e7a5fb2339db49c7baadc341f137aff87c8e0 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages