Make startup of of WPR components resilient to not starting up previous steps.

Make startup of of WPR components resilient to not starting up previous steps.

This fixes the redness in the orderfile bot due to the WPR server failing to
start due to certs not being installed.

Committed: https://crrev.com/ccb01814f9dc000b0fec81cffc5e965b5a9c8cd7
Cr-Commit-Position: refs/heads/master@{#325229}

[azarchs, 2015-04-15 08:15:19]

azarchs@chromium.org changed reviewers:
+ pasko@chromium.org

[pasko, 2015-04-15 09:59:02]

that would work, thanks, how about one tiny refactoring?

https://codereview.chromium.org/1089163004/diff/1/tools/cygprofile/profile_an...
File tools/cygprofile/profile_android_startup.py (right):

https://codereview.chromium.org/1089163004/diff/1/tools/cygprofile/profile_an...
tools/cygprofile/profile_android_startup.py:159: if not self._host_http_port or
not self._host_https_port:
I think it's easier to reason about error cases if we had only one indication of
error case, like _wpr_server==None.

Is it possible that _wpr_server.StartServer() would throw? if so, maybe  cleanup
and set _wpr_server to None?

[azarchs, 2015-04-15 10:54:12]

https://codereview.chromium.org/1089163004/diff/1/tools/cygprofile/profile_an...
File tools/cygprofile/profile_android_startup.py (right):

https://codereview.chromium.org/1089163004/diff/1/tools/cygprofile/profile_an...
tools/cygprofile/profile_android_startup.py:159: if not self._host_http_port or
not self._host_https_port:
On 2015/04/15 09:59:02, pasko wrote:
> I think it's easier to reason about error cases if we had only one indication
of
> error case, like _wpr_server==None.
> 
> Is it possible that _wpr_server.StartServer() would throw? if so, maybe 
cleanup
> and set _wpr_server to None?

Done.

[pasko, 2015-04-15 11:36:30]

lgtm thanks!

[azarchs, 2015-04-15 12:03:26]

The CQ bit was checked by azarchs@chromium.org

[commit-bot: I haz the power, 2015-04-15 12:03:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1089163004/20001

[commit-bot: I haz the power, 2015-04-15 12:25:55]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-04-15 12:26:42]

Patchset 2 (id:??) landed as
https://crrev.com/ccb01814f9dc000b0fec81cffc5e965b5a9c8cd7
Cr-Commit-Position: refs/heads/master@{#325229}