Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Unified Diff: BUILD.gn

Issue 1089143002: Make the Android GN debug component build actually build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add better comments about why components_{browser,unit}tests are disabled Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/BUILD.gn » ('j') | base/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index 96fd2e78fcb99321bf1b4fbb810ade2d2d0282bc..50851f1634d8956c868a0a7cbdbff229aa3143d7 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -229,6 +229,13 @@ group("gn_all") {
# Chromedriver shouldn't be compiled on Android.
"//chrome/test/chromedriver:chromedriver_unittests",
+
+ # TODO(GYP): These two targets seem to have issues w/
+ # compiling //components/proximity_auth/cryptauth
cjhopman 2015/04/16 19:13:21 for these, I think that there's probably just thin
Dirk Pranke 2015/04/16 20:31:52 Will keep investigating.
+ # in a shared debug build that needs further triaging.
+ "//components:components_browsertests", # TODO(GYP)
+ "//components:components_unittests", # TODO(GYP)
+
"//extensions:extensions_browsertests",
"//extensions:extensions_unittests",
"//google_apis/gcm:gcm_unit_tests",
« no previous file with comments | « no previous file | base/BUILD.gn » ('j') | base/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698