Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Side by Side Diff: BUILD.gn

Issue 1089143002: Make the Android GN debug component build actually build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add better comments about why components_{browser,unit}tests are disabled Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | base/BUILD.gn » ('j') | base/BUILD.gn » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # This is the root build file for GN. GN will start processing by loading this 5 # This is the root build file for GN. GN will start processing by loading this
6 # file, and recursively load all dependencies until all dependencies are either 6 # file, and recursively load all dependencies until all dependencies are either
7 # resolved or known not to exist (which will cause the build to fail). So if 7 # resolved or known not to exist (which will cause the build to fail). So if
8 # you add a new build file, there must be some path of dependencies from this 8 # you add a new build file, there must be some path of dependencies from this
9 # file to your new one or GN won't know about it. 9 # file to your new one or GN won't know about it.
10 10
(...skipping 211 matching lines...) Expand 10 before | Expand all | Expand 10 after
222 ] 222 ]
223 deps -= [ 223 deps -= [
224 "//chrome", # TODO(GYP) ?? 224 "//chrome", # TODO(GYP) ??
225 "//chrome/test:browser_tests", # TODO(GYP) ?? 225 "//chrome/test:browser_tests", # TODO(GYP) ??
226 "//chrome/test:interactive_ui_tests", # TODO(GYP) ?? 226 "//chrome/test:interactive_ui_tests", # TODO(GYP) ??
227 "//chrome/test:sync_integration_tests", # TODO(GYP) ?? 227 "//chrome/test:sync_integration_tests", # TODO(GYP) ??
228 "//chrome/test:unit_tests", # TODO(GYP) 228 "//chrome/test:unit_tests", # TODO(GYP)
229 229
230 # Chromedriver shouldn't be compiled on Android. 230 # Chromedriver shouldn't be compiled on Android.
231 "//chrome/test/chromedriver:chromedriver_unittests", 231 "//chrome/test/chromedriver:chromedriver_unittests",
232
233 # TODO(GYP): These two targets seem to have issues w/
234 # compiling //components/proximity_auth/cryptauth
cjhopman 2015/04/16 19:13:21 for these, I think that there's probably just thin
Dirk Pranke 2015/04/16 20:31:52 Will keep investigating.
235 # in a shared debug build that needs further triaging.
236 "//components:components_browsertests", # TODO(GYP)
237 "//components:components_unittests", # TODO(GYP)
238
232 "//extensions:extensions_browsertests", 239 "//extensions:extensions_browsertests",
233 "//extensions:extensions_unittests", 240 "//extensions:extensions_unittests",
234 "//google_apis/gcm:gcm_unit_tests", 241 "//google_apis/gcm:gcm_unit_tests",
235 "//ipc:ipc_tests", # TODO(GYP) ?? 242 "//ipc:ipc_tests", # TODO(GYP) ??
236 "//jingle:jingle_unittests", # TODO(GYP) ?? 243 "//jingle:jingle_unittests", # TODO(GYP) ??
237 "//net:hpack_example_generator", 244 "//net:hpack_example_generator",
238 "//net:hpack_fuzz_mutator", 245 "//net:hpack_fuzz_mutator",
239 "//net:hpack_fuzz_wrapper", 246 "//net:hpack_fuzz_wrapper",
240 "//net:net_perftests", 247 "//net:net_perftests",
241 "//net:net_unittests", 248 "//net:net_unittests",
(...skipping 539 matching lines...) Expand 10 before | Expand all | Expand 10 after
781 788
782 # Note: 789 # Note:
783 # (*) Fails but failures match GYP build at time of testing. 790 # (*) Fails but failures match GYP build at time of testing.
784 ] 791 ]
785 792
786 if (enable_nacl) { 793 if (enable_nacl) {
787 deps += [ "//components/nacl:nacl_loader_unittests" ] # PASSES 3/28/2015 794 deps += [ "//components/nacl:nacl_loader_unittests" ] # PASSES 3/28/2015
788 } 795 }
789 } 796 }
790 } 797 }
OLDNEW
« no previous file with comments | « no previous file | base/BUILD.gn » ('j') | base/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698