Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 1089043003: Animations: Register LinkHighlight content layer for animations (Closed)

Created:
5 years, 8 months ago by loyso (OOO)
Modified:
5 years, 8 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Animations: Register LinkHighlight content layer for animations We want to add animations to content layer. So let's register it for animations. Next episode (chromium part): https://codereview.chromium.org/1101823002/ This is a prerequisite to implement compositor animation timelines. https://codereview.chromium.org/947033002/ BUG=394777 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194471

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M Source/web/LinkHighlight.cpp View 1 chunk +1 line, -0 lines 1 comment Download

Messages

Total messages: 9 (3 generated)
loyso (OOO)
5 years, 8 months ago (2015-04-24 03:22:00 UTC) #2
loyso (OOO)
On 2015/04/24 03:22:00, loyso wrote: This is a one-liner. PTAL, anyone?
5 years, 8 months ago (2015-04-24 03:22:33 UTC) #3
loyso (OOO)
https://codereview.chromium.org/1089043003/diff/1/Source/web/LinkHighlight.cpp File Source/web/LinkHighlight.cpp (right): https://codereview.chromium.org/1089043003/diff/1/Source/web/LinkHighlight.cpp#newcode84 Source/web/LinkHighlight.cpp:84: m_contentLayer->layer()->setAnimationDelegate(this); Note: The problem is that LayerAnimationController is not ...
5 years, 8 months ago (2015-04-24 03:26:54 UTC) #4
aelias_OOO_until_Jul13
lgtm
5 years, 8 months ago (2015-04-24 19:25:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1089043003/1
5 years, 8 months ago (2015-04-26 23:58:49 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 01:33:43 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194471

Powered by Google App Engine
This is Rietveld 408576698