Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(824)

Unified Diff: runtime/vm/intermediate_language_ia32.cc

Issue 1089003002: Implement bigint shift intrinsics on IA32. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/intermediate_language_ia32.cc
===================================================================
--- runtime/vm/intermediate_language_ia32.cc (revision 45144)
+++ runtime/vm/intermediate_language_ia32.cc (working copy)
@@ -6171,7 +6171,7 @@
__ cmpl(ECX, Immediate(31));
__ j(ABOVE, &large_shift);
- __ shrdl(left_lo, left_hi); // Shift count in CL.
+ __ shrdl(left_lo, left_hi, ECX); // Shift count in CL.
__ sarl(left_hi, ECX); // Shift count in CL.
__ jmp(&done, Assembler::kNearJump);
@@ -6190,7 +6190,7 @@
__ cmpl(ECX, Immediate(31));
__ j(ABOVE, &large_shift);
- __ shldl(left_hi, left_lo); // Shift count in CL.
+ __ shldl(left_hi, left_lo, ECX); // Shift count in CL.
__ shll(left_lo, ECX); // Shift count in CL.
// Check for overflow by shifting back the high 32 bits
// and comparing with the input.
@@ -6221,7 +6221,7 @@
__ cmpl(ECX, Immediate(31));
__ j(ABOVE, &large_shift);
- __ shldl(left_hi, left_lo); // Shift count in CL.
+ __ shldl(left_hi, left_lo, ECX); // Shift count in CL.
__ shll(left_lo, ECX); // Shift count in CL.
__ jmp(&done, Assembler::kNearJump);

Powered by Google App Engine
This is Rietveld 408576698