Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 1088993004: Update run_mojo_media_renderer.py for shell and service changes. (Closed)

Created:
5 years, 8 months ago by msw
Modified:
5 years, 8 months ago
Reviewers:
xhwang, sky
CC:
chromium-reviews, qsr+mojo_chromium.org, Aaron Boodman, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, feature-media-reviews_chromium.org, darin (slow to review), ben+mojo_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update run_mojo_media_renderer.py for shell and service changes. Updates the script to handle recent changes: html_viewer has moved to components. kiosk_wm is run by default. services built locally, don't need origin mapping? avoid html_document.cc:150 Check failed: !is_headless_ --args-for is deprecated (pass app args as shell args) Also update mojo_media_application.cc arg init. Tested that this works with: gn gen out/Debug --args='is_debug=true use_goma=true proprietary_codecs=true ffmpeg_branding="ChromeOS" enable_media_mojo_renderer=true' ninja -C out/Debug/ -j 1500 -l 10 mojo media/mojo/services components/html_viewer mojo/services/network media/mojo/scripts/run_mojo_media_renderer.py --build-dir out/Debug --verbose http://wxh.kir/ensemble/kqed.html BUG=NONE TEST=Script works (or closer to working...) R=sky@chromium.org,xhwang@chromium.org Committed: https://crrev.com/5ea51a1f1ce3b2e200fc95b232120c1582f31eab Cr-Commit-Position: refs/heads/master@{#326690}

Patch Set 1 #

Patch Set 2 : Append shell and app arguments correctly. #

Patch Set 3 : Remove unnecessary origin and mapping args, broken headless flag; update comments. #

Total comments: 2

Patch Set 4 : Inline --enable-mojo-media-renderer option. #

Total comments: 4

Patch Set 5 : Combine --vmodule switches for html_viewer and media; update comment. #

Patch Set 6 : Remove out of date base::CommandLine init. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -40 lines) Patch
M media/mojo/scripts/run_mojo_media_renderer.py View 1 2 3 4 5 chunks +10 lines, -27 lines 0 comments Download
M media/mojo/services/mojo_media_application.cc View 1 2 3 4 5 2 chunks +0 lines, -13 lines 0 comments Download

Messages

Total messages: 19 (6 generated)
msw
Please take a look; thanks!
5 years, 8 months ago (2015-04-23 19:42:25 UTC) #2
sky
LGTM https://codereview.chromium.org/1088993004/diff/40001/media/mojo/scripts/run_mojo_media_renderer.py File media/mojo/scripts/run_mojo_media_renderer.py (right): https://codereview.chromium.org/1088993004/diff/40001/media/mojo/scripts/run_mojo_media_renderer.py#newcode32 media/mojo/scripts/run_mojo_media_renderer.py:32: options.append("--enable-mojo-media-renderer") nit: I would move to this 30, ...
5 years, 8 months ago (2015-04-23 19:45:37 UTC) #3
msw
https://codereview.chromium.org/1088993004/diff/40001/media/mojo/scripts/run_mojo_media_renderer.py File media/mojo/scripts/run_mojo_media_renderer.py (right): https://codereview.chromium.org/1088993004/diff/40001/media/mojo/scripts/run_mojo_media_renderer.py#newcode32 media/mojo/scripts/run_mojo_media_renderer.py:32: options.append("--enable-mojo-media-renderer") On 2015/04/23 19:45:37, sky wrote: > nit: I ...
5 years, 8 months ago (2015-04-23 19:59:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1088993004/60001
5 years, 8 months ago (2015-04-23 19:59:57 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/58579)
5 years, 8 months ago (2015-04-23 20:09:04 UTC) #9
msw
Xiaohan, please take a look; thanks!
5 years, 8 months ago (2015-04-23 20:10:46 UTC) #10
xhwang
Verified and it's working. Thanks! LGTM % one tiny nit https://codereview.chromium.org/1088993004/diff/60001/media/mojo/scripts/run_mojo_media_renderer.py File media/mojo/scripts/run_mojo_media_renderer.py (right): https://codereview.chromium.org/1088993004/diff/60001/media/mojo/scripts/run_mojo_media_renderer.py#newcode47 ...
5 years, 8 months ago (2015-04-23 22:18:49 UTC) #11
xhwang
https://codereview.chromium.org/1088993004/diff/60001/media/mojo/scripts/run_mojo_media_renderer.py File media/mojo/scripts/run_mojo_media_renderer.py (right): https://codereview.chromium.org/1088993004/diff/60001/media/mojo/scripts/run_mojo_media_renderer.py#newcode34 media/mojo/scripts/run_mojo_media_renderer.py:34: options.append("--vmodule=mojo*service=3") How do I know which option is for ...
5 years, 8 months ago (2015-04-23 22:23:57 UTC) #12
msw
Done; please take another look. +CC John for args FYI. https://codereview.chromium.org/1088993004/diff/60001/media/mojo/scripts/run_mojo_media_renderer.py File media/mojo/scripts/run_mojo_media_renderer.py (right): https://codereview.chromium.org/1088993004/diff/60001/media/mojo/scripts/run_mojo_media_renderer.py#newcode34 ...
5 years, 8 months ago (2015-04-23 22:54:05 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1088993004/100001
5 years, 8 months ago (2015-04-23 22:57:15 UTC) #16
xhwang
LGTM, thanks for fixing this!
5 years, 8 months ago (2015-04-23 22:58:39 UTC) #17
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 8 months ago (2015-04-23 23:31:16 UTC) #18
commit-bot: I haz the power
5 years, 8 months ago (2015-04-23 23:32:50 UTC) #19
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/5ea51a1f1ce3b2e200fc95b232120c1582f31eab
Cr-Commit-Position: refs/heads/master@{#326690}

Powered by Google App Engine
This is Rietveld 408576698