Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: test/unittests/base/platform/semaphore-unittest.cc

Issue 1088993003: Replace OVERRIDE->override and FINAL->final since we now require C++11. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/unittests/base/platform/semaphore-unittest.cc
diff --git a/test/unittests/base/platform/semaphore-unittest.cc b/test/unittests/base/platform/semaphore-unittest.cc
index c68435f87524f36d7490b8b6d8ffef6da5a228c7..9565e0e213d606f242cb44e4b0592f737c2f3ece 100644
--- a/test/unittests/base/platform/semaphore-unittest.cc
+++ b/test/unittests/base/platform/semaphore-unittest.cc
@@ -20,7 +20,7 @@ static const size_t kBufferSize = 987; // GCD(buffer size, alphabet size) = 1
static const size_t kDataSize = kBufferSize * kAlphabetSize * 10;
-class ProducerThread FINAL : public Thread {
+class ProducerThread final : public Thread {
public:
ProducerThread(char* buffer, Semaphore* free_space, Semaphore* used_space)
: Thread(Options("ProducerThread")),
@@ -29,7 +29,7 @@ class ProducerThread FINAL : public Thread {
used_space_(used_space) {}
virtual ~ProducerThread() {}
- virtual void Run() OVERRIDE {
+ virtual void Run() override {
for (size_t n = 0; n < kDataSize; ++n) {
free_space_->Wait();
buffer_[n % kBufferSize] = kAlphabet[n % kAlphabetSize];
@@ -44,7 +44,7 @@ class ProducerThread FINAL : public Thread {
};
-class ConsumerThread FINAL : public Thread {
+class ConsumerThread final : public Thread {
public:
ConsumerThread(const char* buffer, Semaphore* free_space,
Semaphore* used_space)
@@ -54,7 +54,7 @@ class ConsumerThread FINAL : public Thread {
used_space_(used_space) {}
virtual ~ConsumerThread() {}
- virtual void Run() OVERRIDE {
+ virtual void Run() override {
for (size_t n = 0; n < kDataSize; ++n) {
used_space_->Wait();
EXPECT_EQ(kAlphabet[n % kAlphabetSize], buffer_[n % kBufferSize]);
@@ -69,13 +69,13 @@ class ConsumerThread FINAL : public Thread {
};
-class WaitAndSignalThread FINAL : public Thread {
+class WaitAndSignalThread final : public Thread {
public:
explicit WaitAndSignalThread(Semaphore* semaphore)
: Thread(Options("WaitAndSignalThread")), semaphore_(semaphore) {}
virtual ~WaitAndSignalThread() {}
- virtual void Run() OVERRIDE {
+ virtual void Run() override {
for (int n = 0; n < 100; ++n) {
semaphore_->Wait();
ASSERT_FALSE(semaphore_->WaitFor(TimeDelta::FromMicroseconds(1)));
« no previous file with comments | « test/unittests/base/platform/platform-unittest.cc ('k') | test/unittests/compiler/change-lowering-unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698