Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: pkg/analysis_server/test/services/completion/completion_test_util.dart

Issue 1088973008: fix NSM in suggestions with importUri (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: merge Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/test/abstract_context.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/services/completion/completion_test_util.dart
diff --git a/pkg/analysis_server/test/services/completion/completion_test_util.dart b/pkg/analysis_server/test/services/completion/completion_test_util.dart
index b14fa0f9536f7a7c280b52416187803859baf216..17c46d6a68e3db454c64738fd250d07ecb914fe3 100644
--- a/pkg/analysis_server/test/services/completion/completion_test_util.dart
+++ b/pkg/analysis_server/test/services/completion/completion_test_util.dart
@@ -1787,7 +1787,10 @@ abstract class AbstractSelectorSuggestionTest extends AbstractCompletionTest {
}
test_Block_unimported() {
- addSource('/testAB.dart', 'class Foo { }');
+ addPackageSource('myBar', 'bar.dart', 'class Foo2 { Foo2() { } }');
+ addSource(
+ '/proj/testAB.dart', 'import "package:myBar/bar.dart"; class Foo { }');
+ testFile = '/proj/completionTest.dart';
addTestSource('class C {foo(){F^}}');
computeFast();
return computeFull((bool result) {
@@ -1795,6 +1798,10 @@ abstract class AbstractSelectorSuggestionTest extends AbstractCompletionTest {
expect(request.replacementLength, 1);
assertSuggestImportedClass('Foo',
relevance: DART_RELEVANCE_LOW, importUri: 'testAB.dart');
+ // TODO(danrubel) implement
+ assertNotSuggested('Foo2');
+ // assertSuggestImportedClass('Foo2',
+ // relevance: DART_RELEVANCE_LOW, importUri: 'package:myBar/bar.dart');
assertSuggestImportedClass('Future',
relevance: DART_RELEVANCE_LOW, importUri: 'dart:async');
});
« no previous file with comments | « pkg/analysis_server/test/abstract_context.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698