Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Issue 1088973003: [Password Manager] Relax matching for username overrides. (Closed)

Created:
5 years, 8 months ago by Garrett Casto
Modified:
5 years, 8 months ago
Reviewers:
dvadym
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, browser-components-watch_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org, rouslan+autofillwatch_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Password Manager] Relax matching for username overrides. Currently if the form changes in any way between parsing and form submission any server overrides for the form will be ignored. Relax the matching to only take into account name and action for the form and name for the field. This is similar to how Autofill matches. BUG=476092 Committed: https://crrev.com/2c03ed4ed9b71cd79380a6df7641c1da74dd04fd Cr-Commit-Position: refs/heads/master@{#325380}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -7 lines) Patch
M chrome/renderer/autofill/password_autofill_agent_browsertest.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M components/autofill/content/renderer/password_form_conversion_utils.cc View 1 chunk +13 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1088973003/1
5 years, 8 months ago (2015-04-15 00:19:39 UTC) #2
Garrett Casto
5 years, 8 months ago (2015-04-15 00:19:50 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/56384)
5 years, 8 months ago (2015-04-15 00:31:12 UTC) #6
dvadym
LGTM
5 years, 8 months ago (2015-04-15 12:01:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1088973003/1
5 years, 8 months ago (2015-04-16 01:01:34 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-16 02:32:46 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 02:33:42 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2c03ed4ed9b71cd79380a6df7641c1da74dd04fd
Cr-Commit-Position: refs/heads/master@{#325380}

Powered by Google App Engine
This is Rietveld 408576698