implement tear offs

lib/runtime/dart/convert.js

 var convert;
 (function(exports) {
   'use strict';
   let ASCII = new AsciiCodec();
   let _ASCII_MASK = 127;
   let _allowInvalid = Symbol('_allowInvalid');
   let _nameToEncoding = Symbol('_nameToEncoding');
   let Codec$ = dart.generic(function(S, T) {
     class Codec extends core.Object {
       Codec() {
@@ skipping 800 matching lines @@
       super.ChunkedConversionSink();
     }
     [_addChunk](chunk, start, end) {
       this[_sink].addSlice(chunk, start, end, false);
     }
     add(object) {
       if (this[_isDone]) {
         throw new core.StateError("Only one call to add allowed");
       }
       this[_isDone] = true;
-      _JsonUtf8Stringifier.stringify(object, this[_indent], dart.as(this[_toEncodable$], dart.functionType(dart.dynamic, [core.Object])), this[_bufferSize], this[_addChunk]);
+      _JsonUtf8Stringifier.stringify(object, this[_indent], dart.as(this[_toEncodable$], dart.functionType(dart.dynamic, [core.Object])), this[_bufferSize], this[_addChunk].bind(this));
       this[_sink].close();
     }
     close() {
       if (!dart.notNull(this[_isDone])) {
         this[_isDone] = true;
         this[_sink].close();
       }
     }
   }
   class JsonDecoder extends Converter$(core.String, core.Object) {
@@ skipping 536 matching lines @@
       }
     }
   }
   let _addSlice = Symbol('_addSlice');
   class LineSplitter extends Converter$(core.String, core.List$(core.String)) {
     LineSplitter() {
       super.Converter();
     }
     convert(data) {
       let lines = new (core.List$(core.String))();
-      _LineSplitterSink[_addSlice](data, 0, data.length, true, lines[core.$add]);
+      _LineSplitterSink[_addSlice](data, 0, data.length, true, lines[core.$add].bind(lines));
       return lines;
     }
     startChunkedConversion(sink) {
       if (!dart.is(sink, StringConversionSink)) {
         sink = new StringConversionSink.from(sink);
       }
       return new _LineSplitterSink(dart.as(sink, StringConversionSink));
     }
   }
   let _carry = Symbol('_carry');
   let _LF = Symbol('_LF');
   let _CR = Symbol('_CR');
   class _LineSplitterSink extends StringConversionSinkBase {
     _LineSplitterSink(sink) {
       this[_sink] = sink;
       this[_carry] = null;
     }
     addSlice(chunk, start, end, isLast) {
       if (this[_carry] != null) {
         chunk = dart.notNull(this[_carry]) + dart.notNull(chunk.substring(start, end));
         start = 0;
         end = chunk.length;
         this[_carry] = null;
       }
-      this[_carry] = _LineSplitterSink[_addSlice](chunk, start, end, isLast, this[_sink].add);
+      this[_carry] = _LineSplitterSink[_addSlice](chunk, start, end, isLast, this[_sink].add.bind(this[_sink]));
       if (isLast)
         this[_sink].close();
     }
     close() {
       this.addSlice('', 0, 0, true);
     }
     static [_addSlice](chunk, start, end, isLast, adder) {
       let pos = start;
       while (dart.notNull(pos) < dart.notNull(end)) {
         let skip = 0;
@@ skipping 155 matching lines @@
       if (isLast)
         this.close();
     }
     add(str) {
       return this[_stringSink].write(str);
     }
     asUtf8Sink(allowMalformed) {
       return new _Utf8StringSinkAdapter(this, this[_stringSink], allowMalformed);
     }
     asStringSink() {
-      return new ClosableStringSink.fromStringSink(this[_stringSink], this.close);
+      return new ClosableStringSink.fromStringSink(this[_stringSink], dart.bind(this, 'close'));

[Jacob, 2015/04/21 20:27:56]

I don't get why this case is dart.bind(this, 'close') instead of
this.close.bind(this)

seems like "this" is stateless. what am I missing?

[Jennifer Messerly, 2015/04/21 21:11:06]

Hmmm. The stateless checker may only work for identifiers (which `this` is not).
Well the good news, improving it here probably improves it everywhere that uses
isStateless :)

Does it look good other than this? It might be cleaner to fix in a follow up, in
case there are other diffs to baselines

     }
   }
   class _StringCallbackSink extends _StringSinkConversionSink {
     _StringCallbackSink(callback) {
       this[_callback] = callback;
       super._StringSinkConversionSink(new core.StringBuffer());
     }
     close() {
       let buffer = dart.as(this[_stringSink], core.StringBuffer);
       let accumulated = buffer.toString();
@@ skipping 837 matching lines @@
   exports.LineSplitter = LineSplitter;
   exports.StringConversionSink = StringConversionSink;
   exports.ClosableStringSink = ClosableStringSink;
   exports.UNICODE_REPLACEMENT_CHARACTER_RUNE = UNICODE_REPLACEMENT_CHARACTER_RUNE;
   exports.UNICODE_BOM_CHARACTER_RUNE = UNICODE_BOM_CHARACTER_RUNE;
   exports.UTF8 = UTF8;
   exports.Utf8Codec = Utf8Codec;
   exports.Utf8Encoder = Utf8Encoder;
   exports.Utf8Decoder = Utf8Decoder;
 })(convert || (convert = {}));