Issue 1088933007: Domain Reliability: Add was_proxied field to beacons.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1088933007: Domain Reliability: Add was_proxied field to beacons. (Closed)

Created:
5 years, 8 months ago by Deprecated (see juliatuttle)

Modified:
5 years, 8 months ago

Reviewers:
davidben

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Domain Reliability: Add was_proxied field to beacons. This makes it explicit why server_ip is blank when the connection was proxied, so we can tell when it's blank because of a bug instead. BUG= Committed: https://crrev.com/50ff1a27f7e6c1b7855c55f9d02c8b27e9140f0b Cr-Commit-Position: refs/heads/master@{#326739}

Patch Set 1 #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -2 lines)			Patch
M	components/domain_reliability/beacon.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	components/domain_reliability/beacon.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	components/domain_reliability/context_unittest.cc	View	3 chunks	+5 lines, -2 lines	0 comments	Download
M	components/domain_reliability/monitor.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1088933007/1

5 years, 8 months ago (2015-04-24 02:26:51 UTC) #4

commit-bot: I haz the power

5 years, 8 months ago (2015-04-24 04:18:17 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/50ff1a27f7e6c1b7855c55f9d02c8b27e9140f0b
Cr-Commit-Position: refs/heads/master@{#326739}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages