Issue 1088933006: Add IE support.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1088933006: Add IE support. (Closed)

Created:
5 years, 8 months ago by nweiz

Modified:
5 years, 8 months ago

Reviewers:
kevmoo

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/test@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Add IE support. Closes #31 R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/f169f3d64e880472f82e9c2b744bb57329d6122d

Patch Set 2 : Code review changes #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+63 lines, -103 lines)			Patch
M	.status	View		2 chunks	+6 lines, -3 lines	0 comments	Download
M	CHANGELOG.md	View		1 chunk	+1 line, -1 line	0 comments	Download
M	README.md	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	lib/src/backend/test_platform.dart	View	1	1 chunk	+15 lines, -2 lines	0 comments	Download
M	lib/src/executable.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
A +	lib/src/runner/browser/internet_explorer.dart	View		5 chunks	+21 lines, -44 lines	0 comments	Download
M	lib/src/runner/browser/server.dart	View		2 chunks	+3 lines, -1 line	0 comments	Download
A +	test/runner/browser/internet_explorer_test.dart	View		2 chunks	+12 lines, -51 lines	0 comments	Download
M	test/runner/runner_test.dart	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

kevmoo

code LGTM, modulo missing "is" https://codereview.chromium.org/1088933006/diff/1/test/runner/runner_test.dart File test/runner/runner_test.dart (right): https://codereview.chromium.org/1088933006/diff/1/test/runner/runner_test.dart#newcode44 test/runner/runner_test.dart:44: (Platform.Windows ? ", ie" ...

5 years, 8 months ago (2015-04-23 00:17:41 UTC) #2

nweiz

5 years, 8 months ago (2015-04-23 00:50:46 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
f169f3d64e880472f82e9c2b744bb57329d6122d (presubmit successful).

Expand Messages | Collapse Messages

Issue 1088933006: Add IE support. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Code review changes #

Messages