Issue 1088933005: Throw exception if querying SVGAnimationElement with unresolved interval

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1088933005: Throw exception if querying SVGAnimationElement with unresolved interval (Closed)

Created:
5 years, 8 months ago by fs

Modified:
5 years, 8 months ago

Reviewers:
kouhei (in TOK)

CC:
blink-reviews, shans, vivekg_samsung, fs, vivekg, kouhei+svg_chromium.org, rwlbuis, krit, arv+blink, dstockwell, Timothy Loh, gyuyoung2, pdr+svgwatchlist_chromium.org, Eric Willigers, Steve Block, rjwright, darktears, blink-reviews-animation_chromium.org, Mike Lawther (Google), ed+blinkwatch_opera.com, f(malita), Inactive, Stephen Chennney

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Throw exception if querying SVGAnimationElement with unresolved interval http://www.w3.org/TR/SVG11/animate.html#__svg__SVGAnimationElement__getStartTime http://www.w3.org/TR/SVG11/animate.html#__svg__SVGAnimationElement__getSimpleDuration Matches Gecko. BUG=477828 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194141

Patch Set 1 #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+39 lines, -9 lines)			Patch
A	LayoutTests/svg/dom/SVGAnimationElement-exceptions.html	View	1 chunk	+18 lines, -0 lines	0 comments	Download
M	Source/core/svg/SVGAnimationElement.h	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	Source/core/svg/SVGAnimationElement.cpp	View	3 chunks	+15 lines, -5 lines	0 comments	Download
M	Source/core/svg/SVGAnimationElement.idl	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1088933005/1

5 years, 8 months ago (2015-04-21 15:49:53 UTC) #4

commit-bot: I haz the power

5 years, 8 months ago (2015-04-21 15:56:18 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194141

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages