Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 1088933003: PlzNavigate: use the right helper functions in OverscrollNavigationOverlayTests (Closed)

Created:
5 years, 8 months ago by clamy
Modified:
4 years, 11 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PlzNavigate: use the right helper functions in OverscrollNavigationOverlayTests This CL modifies OverscrollNavigationOverlayTests so that they use TestRenderFrameHost::PrepareForCommit and TestRenderFrameHost::SendNavigate instead of TestWebContents::CommitPendingNavigation. This allows values for CrossNavigationPending to be properly set with browser-side navigation. BUG=439423 Committed: https://crrev.com/73d097cbe1db3f780eb30d5fb88713066d2560f7 Cr-Commit-Position: refs/heads/master@{#325427}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M content/browser/web_contents/aura/overscroll_navigation_overlay_unittest.cc View 4 chunks +7 lines, -3 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
clamy
@nasko, sadrul: PTAL @carlosk, fdegans: FYI This fixes the test failures on the browser-side-navigation bot ...
5 years, 8 months ago (2015-04-14 15:11:19 UTC) #2
nasko
LGTM https://codereview.chromium.org/1088933003/diff/1/content/browser/web_contents/aura/overscroll_navigation_overlay_unittest.cc File content/browser/web_contents/aura/overscroll_navigation_overlay_unittest.cc (right): https://codereview.chromium.org/1088933003/diff/1/content/browser/web_contents/aura/overscroll_navigation_overlay_unittest.cc#newcode256 content/browser/web_contents/aura/overscroll_navigation_overlay_unittest.cc:256: main_test_rfh()->SendNavigate( nit: I kinda like the CommitPendingNavigation paradigm, ...
5 years, 8 months ago (2015-04-14 16:13:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1088933003/1
5 years, 8 months ago (2015-04-16 12:18:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-16 12:56:18 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 12:57:11 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/73d097cbe1db3f780eb30d5fb88713066d2560f7
Cr-Commit-Position: refs/heads/master@{#325427}

Powered by Google App Engine
This is Rietveld 408576698