Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 1088933002: Revert of Add a WorkerScheduler and a WebThreadImplForWorker (Closed)

Created:
5 years, 8 months ago by alex clarke (OOO till 29th)
Modified:
5 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, kinuko+watch, kinuko, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, picksi1, scheduler-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add a WorkerScheduler and a WebThreadImplForWorker (patchset #16 id:380001 of https://codereview.chromium.org/1033643004/) Reason for revert: Looks like this broke ImageFrameGeneratorTest.incompleteDecodeBecomesCompleteMultiThreaded Original issue's description: > Add a WorkerScheduler and a WebThreadImplForWorker > > Adds a simple WorkerScheduler which supports Default and Idle Tasks (via > Long Idle Periods). A follow up Blink patch will refactor > WorkerThread.cpp to use these Idle Tasks. > > A WorkerSceduler is a pre-requisite for refactoring away the Blink > Timer Heap as described in: > https://docs.google.com/document/d/163ow-1wjd6L0rAN3V_U6t12eqVkq4mXDDjVaA4OuvCA/edit?usp=sharing > > BUG=463143 > > Committed: https://crrev.com/510ed9c42029e1b2924ac05082c958591f029624 > Cr-Commit-Position: refs/heads/master@{#324847} > > Committed: https://crrev.com/b37d4c285dc2f505b006187d2651f6db96d9a42c > Cr-Commit-Position: refs/heads/master@{#325026} TBR=jochen@chromium.org,rmcilroy@chromium.org,skyostil@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=463143 Committed: https://crrev.com/ebe9b674fb28f45d78dda654ddb85c7cdb127953 Cr-Commit-Position: refs/heads/master@{#325037}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+552 lines, -1645 lines) Patch
M content/child/blink_platform_impl.cc View 2 chunks +2 lines, -3 lines 0 comments Download
D content/child/scheduler/null_worker_scheduler.h View 1 chunk +0 lines, -36 lines 0 comments Download
D content/child/scheduler/null_worker_scheduler.cc View 1 chunk +0 lines, -51 lines 0 comments Download
M content/child/scheduler/scheduler_helper.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/child/scheduler/scheduler_helper.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/child/scheduler/scheduler_helper_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
D content/child/scheduler/webthread_impl_for_worker_scheduler.h View 1 chunk +0 lines, -50 lines 0 comments Download
D content/child/scheduler/webthread_impl_for_worker_scheduler.cc View 1 chunk +0 lines, -85 lines 0 comments Download
D content/child/scheduler/webthread_impl_for_worker_scheduler_unittest.cc View 1 chunk +0 lines, -170 lines 0 comments Download
D content/child/scheduler/worker_scheduler.h View 1 chunk +0 lines, -65 lines 0 comments Download
D content/child/scheduler/worker_scheduler.cc View 1 chunk +0 lines, -34 lines 0 comments Download
D content/child/scheduler/worker_scheduler_impl.h View 1 chunk +0 lines, -61 lines 0 comments Download
D content/child/scheduler/worker_scheduler_impl.cc View 1 chunk +0 lines, -92 lines 0 comments Download
D content/child/scheduler/worker_scheduler_impl_unittest.cc View 1 chunk +0 lines, -420 lines 0 comments Download
M content/child/threaded_data_provider.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/child/threaded_data_provider.cc View 6 chunks +6 lines, -6 lines 0 comments Download
D content/child/webthread_base.h View 1 chunk +0 lines, -80 lines 0 comments Download
D content/child/webthread_base.cc View 1 chunk +0 lines, -164 lines 0 comments Download
A content/child/webthread_impl.h View 1 chunk +85 lines, -0 lines 0 comments Download
A content/child/webthread_impl.cc View 1 chunk +158 lines, -0 lines 0 comments Download
M content/content_child.gypi View 3 chunks +2 lines, -10 lines 0 comments Download
M content/content_renderer.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M content/content_tests.gypi View 2 chunks +1 line, -3 lines 0 comments Download
M content/renderer/renderer_blink_platform_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/renderer_blink_platform_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/scheduler/renderer_scheduler_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
D content/renderer/scheduler/webthread_impl_for_renderer_scheduler.h View 1 chunk +0 lines, -42 lines 0 comments Download
D content/renderer/scheduler/webthread_impl_for_renderer_scheduler.cc View 1 chunk +0 lines, -52 lines 0 comments Download
D content/renderer/scheduler/webthread_impl_for_renderer_scheduler_unittest.cc View 1 chunk +0 lines, -202 lines 0 comments Download
A content/renderer/scheduler/webthread_impl_for_scheduler.h View 1 chunk +41 lines, -0 lines 0 comments Download
A content/renderer/scheduler/webthread_impl_for_scheduler.cc View 1 chunk +45 lines, -0 lines 0 comments Download
A content/renderer/scheduler/webthread_impl_for_scheduler_unittest.cc View 1 chunk +202 lines, -0 lines 0 comments Download
M content/test/test_blink_web_unit_test_support.cc View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
alex clarke (OOO till 29th)
Created Revert of Add a WorkerScheduler and a WebThreadImplForWorker
5 years, 8 months ago (2015-04-14 13:52:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1088933002/1
5 years, 8 months ago (2015-04-14 13:52:32 UTC) #2
alex clarke (OOO till 29th)
5 years, 8 months ago (2015-04-14 13:52:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1088933002/1
5 years, 8 months ago (2015-04-14 13:56:18 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-14 13:57:57 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ebe9b674fb28f45d78dda654ddb85c7cdb127953 Cr-Commit-Position: refs/heads/master@{#325037}
5 years, 8 months ago (2015-04-14 13:59:26 UTC) #7
alex clarke (OOO till 29th)
5 years, 8 months ago (2015-04-14 14:37:31 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1085863002/ by alexclarke@chromium.org.

The reason for reverting is: False alarm. The patch was good, the failure was
from monday..

Powered by Google App Engine
This is Rietveld 408576698