Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 1088923003: Remove TSAN suppression related to webrtc::EventPosix (Closed)

Created:
5 years, 8 months ago by Guido Urdaneta
Modified:
5 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove TSAN suppression related to webrtc::EventPosix A race used to be detected by TSAN when running WebRtcInternalsBrowserTest.WithRealPeerConnectionCall This test is currently disabled due to flakiness (see crbug.com/272413). However, the webrtc::EventPosix issues were refactored and no longer cause races with that (disabled) test (or any other test). BUG=246970 Committed: https://crrev.com/31cb44c6430327dff8765ebaf8f51f18aa1d7045 Cr-Commit-Position: refs/heads/master@{#325204}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M build/sanitizers/tsan_suppressions.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Guido Urdaneta
5 years, 8 months ago (2015-04-14 16:06:24 UTC) #2
henrika (OOO until Aug 14)
LGTM
5 years, 8 months ago (2015-04-14 16:32:38 UTC) #3
pbos
lgtm
5 years, 8 months ago (2015-04-14 20:49:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1088923003/1
5 years, 8 months ago (2015-04-15 07:37:01 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-15 07:41:03 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 07:42:55 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/31cb44c6430327dff8765ebaf8f51f18aa1d7045
Cr-Commit-Position: refs/heads/master@{#325204}

Powered by Google App Engine
This is Rietveld 408576698