Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issue 1088913002: [turbofan] Load immortal heap objects from the heap roots. (Closed)

Created:
5 years, 8 months ago by Benedikt Meurer
Modified:
5 years, 8 months ago
Reviewers:
dcarney
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Load immortal heap objects from the heap roots. It's cheaper to materialize heap constants by loading from the roots array instead of embedding the constant into the instruction stream, at least on x64, arm and arm64. Drive-by-fix: Also cleanup the materialize constant from frame optimization. R=dcarney@chromium.org Committed: https://crrev.com/5d2de78a771b8ff1ac59fbdf634bffd01709b554 Cr-Commit-Position: refs/heads/master@{#27818}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -51 lines) Patch
M src/compiler/arm/code-generator-arm.cc View 1 chunk +6 lines, -11 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 1 chunk +6 lines, -11 lines 0 comments Download
M src/compiler/code-generator.h View 1 chunk +9 lines, -0 lines 0 comments Download
M src/compiler/code-generator.cc View 1 chunk +30 lines, -0 lines 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 1 chunk +4 lines, -18 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 chunk +6 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 8 months ago (2015-04-14 12:20:49 UTC) #1
Benedikt Meurer
Please take a look.
5 years, 8 months ago (2015-04-14 12:21:33 UTC) #2
dcarney
lgtm
5 years, 8 months ago (2015-04-14 12:28:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1088913002/1
5 years, 8 months ago (2015-04-14 12:32:29 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-14 12:50:47 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-14 12:51:00 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5d2de78a771b8ff1ac59fbdf634bffd01709b554
Cr-Commit-Position: refs/heads/master@{#27818}

Powered by Google App Engine
This is Rietveld 408576698