Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1088903003: Remove unused app_ids from app api whitelist. (Closed)

Created:
5 years, 8 months ago by Gaurav
Modified:
5 years, 8 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused app_ids from app api whitelist. BUG=477050 Committed: https://crrev.com/493f732bdc865c3fa35476104233344c2fe1a2d8 Cr-Commit-Position: refs/heads/master@{#325562}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M chrome/common/extensions/api/_permission_features.json View 2 chunks +1 line, -7 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
Gaurav
5 years, 8 months ago (2015-04-14 20:20:49 UTC) #2
Ken Rockot(use gerrit already)
LGTM!
5 years, 8 months ago (2015-04-15 17:09:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1088903003/1
5 years, 8 months ago (2015-04-15 17:40:47 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/48434)
5 years, 8 months ago (2015-04-15 20:00:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1088903003/1
5 years, 8 months ago (2015-04-16 09:52:08 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/48759)
5 years, 8 months ago (2015-04-16 11:31:18 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1088903003/1
5 years, 8 months ago (2015-04-16 15:22:30 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/48844)
5 years, 8 months ago (2015-04-16 16:57:51 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1088903003/1
5 years, 8 months ago (2015-04-16 22:00:14 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-17 00:13:03 UTC) #18
commit-bot: I haz the power
5 years, 8 months ago (2015-04-17 00:14:12 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/493f732bdc865c3fa35476104233344c2fe1a2d8
Cr-Commit-Position: refs/heads/master@{#325562}

Powered by Google App Engine
This is Rietveld 408576698