Issue 10889014: Fix and expand upon BubbleDelegateTests.

Issue 10889014: Fix and expand upon BubbleDelegateTests. (Closed)

Created:
8 years, 3 months ago by msw

Modified:
8 years, 3 months ago

Reviewers:
sadrul, Ben Goodger (Google)

CC:
chromium-reviews, tfarina, alicet1, msw+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix and expand upon BubbleDelegateTests. BubbleDelegateTest.ResetAnchorWidget was previously failing and crashing because of it's widget ownership pattern and lack of close_on_deactivate. Add TestWidgetObserver to observe bubbles closing. Ensure the bubble widget closes as expected in each test. BUG=none TEST=unit tests pass Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153843

Patch Set 1 #

Patch Set 2 : Add TestWidgetObserver, expand/add tests. #

Total comments: 2

Patch Set 3 : Address comment. #

Patch Set 4 : Fix more spacing, add anon namespace closing comment. #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+95 lines, -28 lines)			Patch
	M	ui/views/bubble/bubble_delegate_unittest.cc	View	1 2 3	3 chunks	+95 lines, -28 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

Thanks for fixing this! LGTM. https://chromiumcodereview.appspot.com/10889014/diff/3/ui/views/bubble/bubble_delegate_unittest.cc File ui/views/bubble/bubble_delegate_unittest.cc (right): https://chromiumcodereview.appspot.com/10889014/diff/3/ui/views/bubble/bubble_delegate_unittest.cc#newcode16 ui/views/bubble/bubble_delegate_unittest.cc:16: public: 1-space indent here ...

8 years, 3 months ago (2012-08-28 22:21:19 UTC) #2

msw

https://chromiumcodereview.appspot.com/10889014/diff/3/ui/views/bubble/bubble_delegate_unittest.cc File ui/views/bubble/bubble_delegate_unittest.cc (right): https://chromiumcodereview.appspot.com/10889014/diff/3/ui/views/bubble/bubble_delegate_unittest.cc#newcode16 ui/views/bubble/bubble_delegate_unittest.cc:16: public: On 2012/08/28 22:21:19, Ben Goodger (Google) wrote: > ...

8 years, 3 months ago (2012-08-28 22:28:31 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/10889014/1003

8 years, 3 months ago (2012-08-28 22:28:49 UTC) #4

commit-bot: I haz the power

Commit queue failed due to new patchset.

8 years, 3 months ago (2012-08-29 01:10:30 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/10889014/4

8 years, 3 months ago (2012-08-29 01:10:35 UTC) #6

Change committed as 153843

Expand Messages | Collapse Messages