Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4629)

Unified Diff: chrome/common/extensions/api/file_system_provider.idl

Issue 1088883002: Add events for configuring and adding new providers to FSP API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/api/file_system_provider.idl
diff --git a/chrome/common/extensions/api/file_system_provider.idl b/chrome/common/extensions/api/file_system_provider.idl
index 0b589617243fe5d7862ad3ceaa4d8b06f691329d..353c891485b6990814d83fd3a3864f5f4ab9e170 100644
--- a/chrome/common/extensions/api/file_system_provider.idl
+++ b/chrome/common/extensions/api/file_system_provider.idl
@@ -44,7 +44,7 @@ namespace fileSystemProvider {
// Source of the file system data.
enum FileSystemSource {
// The file system is handling a file, eg. an archive file obtained via the
- // <code>OnLaunched</code> event and the <code>file_handlers</code> manifest
+ // <code>onLaunched</code> event and the <code>file_handlers</code> manifest
// entry.
FILE,
@@ -647,6 +647,22 @@ namespace fileSystemProvider {
ProviderSuccessCallback successCallback,
ProviderErrorCallback errorCallback);
+ // Raised when showing a configuration dialog for <code>fileSystemId</code>
+ // is requested. If it's not supported, then this event must not be handled.
+ [maxListeners=1] static void onConfigureDialogRequested(
+ ConfigureRequestedOptions options,
benwells 2015/04/15 01:13:42 Where is ConfigureRequestedOptions defined?
mtomasz 2015/04/15 03:34:27 Sorry, I uploaded an incorrect patch. Done.
+ ProviderSuccessCallback successCallback,
+ ProviderErrorCallback errorCallback);
+
+ // Raised when showing a dialog for mounting a new file system is requested.
+ // If the extension/app is a file handler, then this event shouldn't be
+ // handled. Instead <code>onLaunched</code> should be handled in order to
+ // mount new file systems without showing an unnecessary UI.
+ [maxListeners=1] static void onAddDialogRequested(
+ ConfigureRequestedOptions options,
+ ProviderSuccessCallback successCallback,
+ ProviderErrorCallback errorCallback);
+
// Raised when setting a new directory watcher is requested. If an error
// occurs, then <code>errorCallback</code> must be called.
[maxListeners=1, nodoc] static void onAddWatcherRequested(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698