Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1088853004: Add retries to gs upload (Closed)

Created:
5 years, 8 months ago by borenet
Modified:
5 years, 8 months ago
Reviewers:
jcgregorio, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/common.git@master
Target Ref:
refs/heads/master
Project:
skiacommon
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Don't stop a thread when a single upload fails #

Total comments: 2

Patch Set 3 : Fix sleep #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -7 lines) Patch
M py/utils/gs_utils.py View 1 2 4 chunks +29 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
borenet
5 years, 8 months ago (2015-04-14 16:58:01 UTC) #2
mtklein
https://codereview.chromium.org/1088853004/diff/20001/py/utils/gs_utils.py File py/utils/gs_utils.py (right): https://codereview.chromium.org/1088853004/diff/20001/py/utils/gs_utils.py#newcode417 py/utils/gs_utils.py:417: time.sleep(math.pow(2, range)) time.sleep(2 ** retry) ?
5 years, 8 months ago (2015-04-14 17:17:14 UTC) #3
jcgregorio
lgtm
5 years, 8 months ago (2015-04-14 17:18:00 UTC) #4
borenet
https://codereview.chromium.org/1088853004/diff/20001/py/utils/gs_utils.py File py/utils/gs_utils.py (right): https://codereview.chromium.org/1088853004/diff/20001/py/utils/gs_utils.py#newcode417 py/utils/gs_utils.py:417: time.sleep(math.pow(2, range)) On 2015/04/14 17:17:14, mtklein wrote: > time.sleep(2 ...
5 years, 8 months ago (2015-04-14 17:20:19 UTC) #5
mtklein
lgtm
5 years, 8 months ago (2015-04-14 17:20:44 UTC) #6
borenet
5 years, 8 months ago (2015-04-14 17:24:48 UTC) #9
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
89823b3bbe978dec013d5a41e2ea096493e6f194 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698