Issue 1088833008: update analyzer to 0.24.4 and remove an old workaround

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1088833008: update analyzer to 0.24.4 and remove an old workaround (Closed)

Created:
5 years, 8 months ago by Jennifer Messerly

Modified:
5 years, 8 months ago

Reviewers:
Leaf

CC:
dev-compiler+reviews_dartlang.org

Base URL:
git@github.com:dart-lang/dev_compiler.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

update analyzer to 0.24.4 and remove an old workaround stackTrace was fixed in CL https://codereview.chromium.org/1060373003/ for analyzer also update a comment in resolver.dart to explain why we need to visit the MethodInvocation's methodName identifier. R=leafp@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/13e6be5afe7a99e9fd66645b510958db25262062

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -18 lines)			Patch
	M	lib/src/checker/resolver.dart	View		2 chunks	+6 lines, -17 lines	0 comments	Download
	M	pubspec.yaml	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (1 generated)

Jennifer Messerly

5 years, 8 months ago (2015-04-14 19:50:03 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
13e6be5afe7a99e9fd66645b510958db25262062 (presubmit successful).