Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1088833006: New urls for the check.googlezip.net test pages. (Closed)

Created:
5 years, 8 months ago by megjablon
Modified:
5 years, 8 months ago
Reviewers:
sclittle
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

New urls for the check.googlezip.net test pages. The Chrome-Proxy integration tests should not be dependent on the Chrome 404 error page. Use the new chrome.googlezip.net/chrome-proxy-header/c_* urls, which have their own resources. BUG=472298 Committed: https://crrev.com/26cfbca7c9736f5d543c258106bae420a0ea9ba3 Cr-Commit-Position: refs/heads/master@{#325341}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py View 1 chunk +1 line, -2 lines 0 comments Download
M tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/client_type.py View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
megjablon
Waiting for xt bypass rules push
5 years, 8 months ago (2015-04-14 19:17:46 UTC) #3
sclittle
lgtm
5 years, 8 months ago (2015-04-14 19:24:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1088833006/20001
5 years, 8 months ago (2015-04-15 22:59:46 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 8 months ago (2015-04-15 23:29:30 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 23:30:24 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/26cfbca7c9736f5d543c258106bae420a0ea9ba3
Cr-Commit-Position: refs/heads/master@{#325341}

Powered by Google App Engine
This is Rietveld 408576698