Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(732)

Issue 1088773004: add GM to test imagefilters + xfermodes (Closed)

Created:
5 years, 8 months ago by reed1
Modified:
5 years, 8 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

add GM to test imagefilters + xfermodes draws incorrectly as is, but will be fixed by https://codereview.chromium.org/1091173003 BUG=skia:3741 Committed: https://skia.googlesource.com/skia/+/7e4186accea094276c9f3c65c64e63ffc59aa644

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : reference bug in code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -0 lines) Patch
A gm/imagefilters.cpp View 1 2 1 chunk +67 lines, -0 lines 0 comments Download
M gyp/gmslides.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
reed1
5 years, 8 months ago (2015-04-20 14:01:52 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1088773004/1
5 years, 8 months ago (2015-04-20 14:02:10 UTC) #4
robertphillips
lgtm + 2 suggestions https://codereview.chromium.org/1088773004/diff/20001/gm/imagefilters.cpp File gm/imagefilters.cpp (right): https://codereview.chromium.org/1088773004/diff/20001/gm/imagefilters.cpp#newcode16 gm/imagefilters.cpp:16: */ Maybe add a link ...
5 years, 8 months ago (2015-04-20 14:13:34 UTC) #5
reed1
https://codereview.chromium.org/1088773004/diff/20001/gm/imagefilters.cpp File gm/imagefilters.cpp (right): https://codereview.chromium.org/1088773004/diff/20001/gm/imagefilters.cpp#newcode16 gm/imagefilters.cpp:16: */ On 2015/04/20 14:13:34, robertphillips wrote: > Maybe add ...
5 years, 8 months ago (2015-04-20 14:20:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1088773004/40001
5 years, 8 months ago (2015-04-20 14:21:01 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-20 14:27:18 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/7e4186accea094276c9f3c65c64e63ffc59aa644

Powered by Google App Engine
This is Rietveld 408576698