Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(765)

Issue 1088763005: Cleanup: Remove unnecessary double-semicolons. (Closed)

Created:
5 years, 8 months ago by tfarina
Modified:
5 years, 8 months ago
Reviewers:
mtklein, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Cleanup: Remove unnecessary double-semicolons. The entries were found by the following command line: $ find . -regex ".*\.[cChH]\(pp\)?" | xargs git grep -e ';;' --and --not -e 'for *(.*;;' Which is a combination of http://stackoverflow.com/a/3858879 and http://gitster.livejournal.com/27674.html BUG=None R=mtklein@google.com Committed: https://skia.googlesource.com/skia/+/567ff2f6143ecb993dbedede402a43feb71c420a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M experimental/PdfViewer/src/SkPdfRenderer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/bitmappremul.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/multipicturedraw.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/textblobtransforms.cpp View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkTArray.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkBitmap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkTypeface.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrDrawTarget.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/images/SkImageDecoder_wbmp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/ports/SkTypeface_win_dw.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/CanvasTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/HashTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
tfarina
5 years, 8 months ago (2015-04-24 20:15:24 UTC) #1
mtklein
lgtm
5 years, 8 months ago (2015-04-24 20:24:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1088763005/1
5 years, 8 months ago (2015-04-24 20:56:06 UTC) #4
commit-bot: I haz the power
Presubmit check for 1088763005-1 failed and returned exit status 1. Running presubmit commit checks ...
5 years, 8 months ago (2015-04-24 20:56:15 UTC) #6
tfarina
Brian, could you rubber stamp this?
5 years, 8 months ago (2015-04-24 20:57:14 UTC) #8
bsalomon
On 2015/04/24 20:57:14, tfarina wrote: > Brian, could you rubber stamp this? lgtm
5 years, 8 months ago (2015-04-27 13:25:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1088763005/1
5 years, 8 months ago (2015-04-27 13:49:50 UTC) #11
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 14:01:51 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/567ff2f6143ecb993dbedede402a43feb71c420a

Powered by Google App Engine
This is Rietveld 408576698